issue #467: add UT

core/src/main/java/com/seleniumtests/core/TestStepManager.java

@@ -234,4 +234,12 @@ public Date getVideoStartDate() {
 	public void setVideoStartDate(Date videoStartDate) {
 		this.videoStartDate = videoStartDate;
 	}
+
+	/**
+	 * For tests only
+	 * @param testSteps
+	 */
+	public void setTestSteps(List<TestStep> testSteps) {
+		this.testSteps = testSteps;
+	}
 }

core/src/main/java/com/seleniumtests/core/testanalysis/ErrorCauseFinder.java

@@ -70,6 +70,7 @@ public List<ErrorCause> findErrorCause() {
 		List<ErrorCause> causes = new ArrayList<>();
 
 		causes.addAll(findErrorInLastStepSnapshots());
+		causes.addAll(compareStepInErrorWithReference());
 
 		return causes;
 	}
@@ -79,9 +80,14 @@ public List<ErrorCause> findErrorCause() {
 	 * If reference cannot be found, skip this step
 	 * @return
 	 */
-	private List<ErrorCause> compareStepInErrorWithReference() {
+	public List<ErrorCause> compareStepInErrorWithReference() {
 		List<ErrorCause> causes = new ArrayList<>();
 
+		// do not seearch again
+		if (TestNGResultUtils.isErrorCauseSearchedInReferencePicture(testResult)) {
+			return causes; 
+		}
+
 		// don't analyze if result has not been recorded on seleniumRobot server
 		TestStepManager testStepManager = TestNGResultUtils.getSeleniumRobotTestContext(testResult).getTestStepManager();
 		if (testStepManager.getLastTestStep().getStepResultId() == null) {
@@ -137,7 +143,7 @@ private List<ErrorCause> compareStepInErrorWithReference() {
 		}
 
 
-		TestNGResultUtils.setErrorCauseInReferencePicture(testResult, true);
+		TestNGResultUtils.setErrorCauseSearchedInReferencePicture(testResult, true);
 
 		return causes;
 	}
@@ -183,10 +189,15 @@ private int compareReferenceToStepSnapshot(File stepSnapshot, File referenceSnap
 	 * Search in snapshots of the last step if there are any displayed errors (error messages or fields in error)
 	 * @return
 	 */
-	private List<ErrorCause> findErrorInLastStepSnapshots() {
+	public List<ErrorCause> findErrorInLastStepSnapshots() {
 
 		List<ErrorCause> causes = new ArrayList<>();
 
+		// do not seearch again
+		if (TestNGResultUtils.isErrorCauseSearchedInLastStep(testResult)) {
+			return causes; 
+		}
+
 		TestStep lastTestStep = TestNGResultUtils.getSeleniumRobotTestContext(testResult).getTestStepManager().getLastTestStep();
 
 		if (lastTestStep != null) {
@@ -196,7 +207,6 @@ private List<ErrorCause> findErrorInLastStepSnapshots() {
 					List<Field> fields = imageFieldDetector.detectFields();
 					List<Label> labels = imageFieldDetector.detectLabels();
 
-
 					// are some text considered as error messages (mainly in red on page)
 					for (Field field: fields) {
 						if ("error_message".equals(field.getClassName())) {
@@ -227,7 +237,7 @@ private List<ErrorCause> findErrorInLastStepSnapshots() {
 				}
 
 			}
-			TestNGResultUtils.setErrorCauseInLastStep(testResult, true);
+			TestNGResultUtils.setErrorCauseSearchedInLastStep(testResult, true);
 		}
 
 		return causes;

core/src/main/java/com/seleniumtests/core/utils/TestNGResultUtils.java

@@ -73,7 +73,7 @@ public class TestNGResultUtils {
 	private static final String DESCRIPTION = "description";			// description of the test method, if any
 	private static final String ERROR_CAUSES = "errorCauses"; 			// list of causes of the test error
 	private static final String ERROR_CAUSE_IN_LAST_STEP = "errorCauseInLastStep"; // true when we have searched for error cause in the last step
-	private static final String ERROR_CAUSE_IN_REFERENCE = "errorCauseInLastStep"; // true when we have searched for error cause by comparing reference picture of the failed step
+	private static final String ERROR_CAUSE_IN_REFERENCE = "errorCauseInReference"; // true when we have searched for error cause by comparing reference picture of the failed step
 
 	private TestNGResultUtils() {
 		// nothing to do
@@ -514,19 +514,19 @@ public static void setErrorCauses(ITestResult testNGResult, List<ErrorCause> err
     	testNGResult.setAttribute(ERROR_CAUSES, errorCauses);
     }
 
-    public static Boolean getErrorCauseInLastStep(ITestResult testNGResult) {
+    public static boolean isErrorCauseSearchedInLastStep(ITestResult testNGResult) {
     	return isReportCreated(testNGResult, ERROR_CAUSE_IN_LAST_STEP);
     }
 
-    public static void setErrorCauseInLastStep(ITestResult testNGResult, Boolean errorCauseInLastStep) {
+    public static void setErrorCauseSearchedInLastStep(ITestResult testNGResult, Boolean errorCauseInLastStep) {
     	testNGResult.setAttribute(ERROR_CAUSE_IN_LAST_STEP, errorCauseInLastStep);
     }
 
-    public static Boolean getErrorCauseInReferencePicture(ITestResult testNGResult) {
+    public static boolean isErrorCauseSearchedInReferencePicture(ITestResult testNGResult) {
     	return isReportCreated(testNGResult, ERROR_CAUSE_IN_REFERENCE);
     }
 
-    public static void setErrorCauseInReferencePicture(ITestResult testNGResult, Boolean errorCauseInReferencePicture) {
+    public static void setErrorCauseSearchedInReferencePicture(ITestResult testNGResult, Boolean errorCauseInReferencePicture) {
     	testNGResult.setAttribute(ERROR_CAUSE_IN_REFERENCE, errorCauseInReferencePicture);
     }
 }

core/src/test/java/com/seleniumtests/it/core/testanalysis/TestErrorCauseFInder.java

@@ -10,7 +10,7 @@
 
 public class TestErrorCauseFInder extends GenericTest {
 
-	@Test(groups={"it"})
+	@Test(groups={"it"}, enabled=false)
 	public void testMultiThreadTests(ITestContext testContext) throws Exception {
 
 		try {

core/src/test/java/com/seleniumtests/ut/util/TestTestNGResultUtil.java

@@ -329,6 +329,30 @@ public void testCustomReportCreatedNull() {
 		Assert.assertFalse(TestNGResultUtils.isCustomReportCreated(tr));
 	}
 
+	@Test(groups={"ut"})
+	public void testErrorCauseSearchedInLastStep() {
+		ITestResult tr = Reporter.getCurrentTestResult(); 
+		TestNGResultUtils.setErrorCauseSearchedInLastStep(tr, true);
+		Assert.assertTrue(TestNGResultUtils.isErrorCauseSearchedInLastStep(tr));
+	}
+	@Test(groups={"ut"})
+	public void testErrorCauseSearchedInLastStepNull() {
+		ITestResult tr = Reporter.getCurrentTestResult(); 
+		Assert.assertFalse(TestNGResultUtils.isErrorCauseSearchedInLastStep(tr));
+	}
+
+	@Test(groups={"ut"})
+	public void testErrorCauseSearchedInReferencePicture() {
+		ITestResult tr = Reporter.getCurrentTestResult(); 
+		TestNGResultUtils.setErrorCauseSearchedInReferencePicture(tr, true);
+		Assert.assertTrue(TestNGResultUtils.isErrorCauseSearchedInReferencePicture(tr));
+	}
+	@Test(groups={"ut"})
+	public void testErrorCauseSearchedInReferencePictureNull() {
+		ITestResult tr = Reporter.getCurrentTestResult(); 
+		Assert.assertFalse(TestNGResultUtils.isErrorCauseSearchedInReferencePicture(tr));
+	}
+
 	@Test(groups={"ut"})
 	public void testNoMoreRetry() {
 		ITestResult tr = Reporter.getCurrentTestResult();