-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unknown doc
attribute Hidden
at nightly
#17
Conversation
Brings down the crates to build, for `rslint-cli` to 119, which was 150 before this commit.
Also breaks my build. :(
|
@@ -41,7 +41,7 @@ pub enum Error { | |||
column: usize, | |||
}, | |||
|
|||
#[doc(Hidden)] | |||
#[doc(hidden)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But that's what I'm fixing. Is there a problem with the cache on the CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a problem with the cache on the CI?
criterion
is being used as a dev-dependency, and it's importing this crate from crates.io.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, there is a cyclic dependency.
But this is a criterion bug nightly so it should be fixed from the criterion repository. From here I can't do anything. Remove dependency, little more.
It's just in the benchmarks I don't think it's important.
To be clear this is a rustc regression (rust-lang/rust#82662), and we hope to fix it in the next nightly (rust-lang/rust#82702), but until then it would be really great if this could be landed with a version bump |
Thanks for the pull request! |
The
Hidden
doc
attribute it's no longer valid at nightly