Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Criterion building with --minimal-versions #196

Merged
merged 6 commits into from
Aug 31, 2018
Merged

Get Criterion building with --minimal-versions #196

merged 6 commits into from
Aug 31, 2018

Conversation

Eh2406
Copy link
Contributor

@Eh2406 Eh2406 commented Aug 27, 2018

This is a start on #183. It gets Criterion to build with --minimal-versions! It has been a long road to get here, but in the process a large number of your dependencies got working with it.

In order to close #183 we would need to add it to CI. Do to the complexity of your CI I did not see how to do that. Suggestions are welcome. Pryor art includes: Cargos CI and walkdir CI

@bheisler
Copy link
Owner

Awesome, thanks! I can handle the CI updates.

I notice that you've updated handlebars - is this necessary for the minimal-versions build to work? The reason I ask is because that version of handlebars (or more specifically, the transitive dependency on pest) doesn't build on Rust 1.20. Technically, Criterion.rs doesn't have to maintain compatibility with 1.20, but I don't want to break that compatibility if I don't have to.

@Eh2406
Copy link
Contributor Author

Eh2406 commented Aug 27, 2018

That is a frustrating situation. The update to handlebars was made to include this PR and each line of that diff is its own PR including this PR to pest_derive.

@bheisler
Copy link
Owner

Ah, I see. That's unfortunate.

In that case, I think I'd rather put this on hold for now. I don't think it makes sense to break compatibility over something like minimal-version support, but I will definitely merge this in next time I have to break compatibility for some other reason.

Thanks again for the help!

@Eh2406
Copy link
Contributor Author

Eh2406 commented Aug 29, 2018

The problems with 1.23 should be fixed now. closing and reopening to trigger new CI.

@Eh2406 Eh2406 reopened this Aug 29, 2018
@bheisler
Copy link
Owner

Looks good to me! Thanks for all the hard work.

@bheisler bheisler merged commit b41f01f into bheisler:master Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI build with --minimal-versions
2 participants