Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new Negative Controls implementation using strategies and manager #74

Closed
wants to merge 17 commits into from
Closed
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 33 additions & 3 deletions config/ruff.toml
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
cache-dir = "~/.cache/ruff"

# iteratively adding files to the include list
cache-dir = "~/.cache/ruff"

# iteratively adding files to the include list
include = [
"src/readii/loaders.py",
"src/readii/feature_extraction.py"
"src/readii/feature_extraction.py",
"src/readii/negative_controls_refactor/**/*.py"
]

# extend-exclude is used to exclude directories from the flake8 checks
Expand All @@ -13,8 +17,8 @@ extend-exclude = [
".pixi/",
"src/readii/image_processing.py",
"src/readii/metadata.py",
"src/readii/negative_controls.py",
"src/readii/pipeline.py",]
"src/readii/pipeline.py",
]

# Same as Black.
line-length = 100
Expand All @@ -40,6 +44,25 @@ line-length = 100
# ignore = ["ANN101"]


# [lint] # commented for now, will iterate on this later
# select = [
# "E",
# "F",
# "W", # flake8
# "C", # mccabe
# # "N", # pep8-naming
# "ANN", # flake8-annotations
# "BLE", # flake8-blind-except
# "B", # flake8-bugbear
# "A", # flake8-builtins
# # "G", # flake8-logging-format
# "ERA", # eradicate
# "RUF", # Ruff-specific rules
# "TCH", # flake8-type-checking
# ]
# ignore = ["ANN101"]


select = [
###########################################################################
# TYPE ANNOTATIONS
Expand Down Expand Up @@ -85,6 +108,9 @@ select = [
# Check for McCabe complexity
# https://docs.astral.sh/ruff/rules/complex-structure/
"C",
# Check for McCabe complexity
# https://docs.astral.sh/ruff/rules/complex-structure/
"C",

###########################################################################
# STANDARDS & STYLE
Expand All @@ -104,8 +130,12 @@ select = [
# Pydocstyle
# https://docs.astral.sh/ruff/rules/#pydocstyle-d
"D",
"D",
]

# Readii uses a lot of camelcase so ignoring pep-8 conventions.
# https://docs.astral.sh/ruff/rules/#pep8-naming-n
# "N",
# Readii uses a lot of camelcase so ignoring pep-8 conventions.
# https://docs.astral.sh/ruff/rules/#pep8-naming-n
# "N",
Expand Down
406 changes: 406 additions & 0 deletions notebooks/viz_neg_4D.ipynb

Large diffs are not rendered by default.

Loading
Loading