Only load users from specific flows #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #24 by only loading the Users from the flows specified in the config rather than *all* the users in the organization.
Travis is currently failing with `Gem::InstallError: rack requires Ruby version >= 2.2.2.`. This bumps the ruby version in travis to hopefully remedy this
|
The rake test seemed to be confusing the flow names given in the config with the expected return value from the "flowdock api" |
|
@bhouse Can this get a merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24 by only loading the Users from the flows specified in the config rather than all the users in the organization. This also addresses the travis build problems by bumping the ruby version.