Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make loader to always behave as stripdeclarations=true #104

Closed
bhovhannes opened this issue Jun 28, 2017 · 2 comments
Closed

Make loader to always behave as stripdeclarations=true #104

bhovhannes opened this issue Jun 28, 2017 · 2 comments

Comments

@bhovhannes
Copy link
Owner

We need to test if SVG without XML declaration works ok in all modern browsers, including IE11 and Edge.
And if this is the case, stripdeclarations option can be removed and set to true to make it a default behaviour of the loader.

cc @malthejorgensen

@iamakulov
Copy link

iamakulov commented Dec 1, 2017

Just tested this.

Here’s the Codepen I used for testing. It includes two sets of img and div with background-image – one with a XML declaration, and another without it: https://codepen.io/iamakulov/pen/KybaEQ

Both sets of images work OK in latest Edge, Chrome, Firefox and IE. To keep options simple, I’d probably deprecate this option and remove it later. What do you think?

Microsoft EdgeHTML 16.16299
image

Google Chrome 64.0.3281.0 (Official Build) canary (64-bit)
image

Firefox 58.0b7 (64-bit)
image

Internet Explorer 11.64.16299.0 (update versions: 11.0.48)
image

@bhovhannes
Copy link
Owner Author

bhovhannes commented Dec 1, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants