-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task entity for electrodes in eeg_face13? #244
Comments
nope, probably a shortcoming of the validator. I think it was decided that electrodes are typically not applied on a task basis (more on a session, or acq basis), thus the task entity is currently "wrong". Seems like we'd need to fiddle with the validator regexps |
as discussed in the maintainers meeting we maybe should re-open the discussion on whether allowing/disallowing a |
copying the discussion from the maintainers mattermost here, in order not to forget: electrodes.tsv and "task" entityI thought Chris' argument was as follows:
Some situation like:
In this example, software would think that With a --> that's how far I understood the point. I might have misunderstood (please correct me). Having thought about this 2 minutes longer, I think this is not an issue and we don't need to allow In the above case, users should just organize as such:
|
The EEG cap being removed and later replaced, makes it similar to a participant getting out of the MRI scanner and back in again. See https://bids-specification.readthedocs.io/en/stable/02-common-principles.html#definitions which mentions that. However, with the MRI scanner the images can be easily realigned, whereas with EEG not. Not only positions, but also impedances will be different. Or consider the gel that might be left in the hair after the first half, which interferes with the measurements in the 2nd half. Imagine that the 2nd half if the experiment is done with another cap. Or even with another amplifier. All of this is technically possible to document by adding a If it were a dataset acquired with different dry electrode systems, or by taking the dry electrode cap off in between, then I would in first instance be fine with it being represented in a single session (hence necessitating |
This kind of information should be mentioned somewhere, no? What would be the best place for that kind of "practical" information? |
I think if someone could manage to condense Roberts explanation into a few sentences, then the section in the spec directly would be a good place: |
I think it should go in the starter kit (or similar), and I think that much more should go there. The starter kit is the closest that we have to the user documentation, whereas the specification is more like the reference documentation. Ideally we would also have many more people contribute to the user documentation, and the process there does not have to be that formal, whereas the specification should be relatively static and well-guarded (a.o. you first have to pass your git exams, and there are N positive reviews required, etc). |
I see this a bit similar as statutory law versus case law (or "jurisprudentie" as we call it in Dutch). See https://en.wikipedia.org/wiki/Case_law or look it up in your native language. |
Good analogy. I was also thinking that this is a bit too practical but was not sure to go in the specs. |
okay, consider me outvoted then - I agree with the general idea from Robert's #244 (comment) then perhaps a starter kit entry would be more suitable |
this was closed in #289 |
Starting to use the bids-schema (thanks again @tsalo for this!) in bids-matlab to parse datasets.
By doing so, my code threw a warning for the
electrode
files that have atask
entity even though they are not supposed to according to the spec.Is that normal?
The text was updated successfully, but these errors were encountered: