Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Travis to block PRs with large files #157

Merged
merged 2 commits into from
May 5, 2019
Merged

Use Travis to block PRs with large files #157

merged 2 commits into from
May 5, 2019

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented May 4, 2019

fixes #156

I am trying to ask Travis to check for file sizes now, blocking everything > 500kb.

@sappelhoff sappelhoff requested a review from choldgraf May 4, 2019 09:42
@choldgraf
Copy link
Collaborator

choldgraf commented May 4, 2019

can we test if this works by committing a big file to this PR once and seeing if travis fails? we can use git commit --amend --no-edit so it doesn't get committed to the git history

@sappelhoff
Copy link
Member Author

I added a ./bigfile of 1MB size, and Travis caught it, see the log: https://travis-ci.org/bids-standard/bids-examples/builds/528367294?utm_source=github_status&utm_medium=notification

I'll revert that commit now, then git amend, and push -f

@choldgraf choldgraf merged commit 1a57c86 into bids-standard:master May 5, 2019
@choldgraf
Copy link
Collaborator

sweet! I'll give this a merge and hopefully it'll work moving forward! Thanks for the addition @sappelhoff

@sappelhoff sappelhoff deleted the add_fs_test branch May 5, 2019 19:37
sappelhoff pushed a commit that referenced this pull request May 18, 2019
Use Travis to block PRs with large files

Former-commit-id: 1a57c86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use git hooks to prevent files of size >= 1MB from being committed
2 participants