-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added BEP032 example dataset #429
Conversation
Co-authored-by: Julia Sprenger <julia.sprenger@rwth-aachen.de>
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
@yarikoptic couldn't just use your commits because: But there were other things to patch up as well. |
never saw such a thing and never had problem committing from github! Were you able to provide/commit suggestions in the past? Please check that you have correct email set in your profile. See https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account |
@effigies sorry for pinging you again, but could you clarify what — if anything — is going on on the other |
The existing https://github.com/bids-standard/bids-examples/branches It is behind |
@robertoostenveld would you prefer to contribute here? this is a copy of the example data from here → https://gin.g-node.org/NeuralEnsemble/BEP032-examples |
I made the bep032 branch here following discussion in the February BEP032 meeting; it is also mentioned in the "2024-02-14_INCF_WG_neuroscience_data_structure" minutes. The reason is that draft examples for the animal ephys cannot be merged yet in master as long as the BEP is not finalized, but we do want animal ephys examples from different contributors to appear side-by-side to allow checking for consistency etc. The shared bep032 branch allows for that. I have just updated the bep032 branch to the latest master and have merged your bep032_data into it. I will create a draft pull request for bep032 into master to replace this one. |
@robertoostenveld but there are other diffs in that branch which to me at least seem BEP032 unrelated, as mentioned in the original post: [deco]~/src/bids-examples ❱ git diff bep032 master --name-only | head -10
README.md
dataset_listing.tsv
eeg_ds003645s_hed/README
eeg_ds003645s_hed/dataset_description.json
eeg_ds003645s_hed/participants.json
eeg_ds003645s_hed/participants.tsv
eeg_ds003645s_hed/sub-002/eeg/sub-002_task-FacePerception_run-1_events.tsv
eeg_ds003645s_hed/sub-002/eeg/sub-002_task-FacePerception_run-2_events.tsv
eeg_ds003645s_hed/sub-002/eeg/sub-002_task-FacePerception_run-3_events.tsv
eeg_ds003645s_hed/sub-003/eeg/sub-003_task-FacePerception_run-1_events.tsv Is something else going on in parallel on that branch? |
Hi @TheChymera I am not sure what changes you are referring to, on https://github.com/bids-standard/bids-examples/pull/430/files I only see your additions in the |
@robertoostenveld yes, you are right, I was misusing |
So as I submitted this pull request, I saw we already have a BEP032 branch. Is that the same thing but with a more up-to-date example? That one seems to be dealing with an eeg face perception dataset though 🤔
@effigies