FIX: IntendedFor errors detected by schema validator #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Status
|
|
https://bids-specification.readthedocs.io/en/stable/common-principles.html#specification-of-paths I'm a fool. |
|
That's the separator, not the initializer. It's followed with:
Which I would interpret to mean that they shouldn't have an initial |
=== Do not change lines below ===
{
"chain": [],
"cmd": "sed -i -e 's/\\(.*IntendedFor.: .\\)sub-.../\\1/' sub-01/ses-meg/meg/sub-01_ses-meg_coordsystem.json sub-02/ses-meg/meg/sub-02_ses-meg_coordsystem.json sub-03/ses-meg/meg/sub-03_ses-meg_coordsystem.json sub-04/ses-meg/meg/sub-04_ses-meg_coordsystem.json sub-05/ses-meg/meg/sub-05_ses-meg_coordsystem.json sub-06/ses-meg/meg/sub-06_ses-meg_coordsystem.json sub-07/ses-meg/meg/sub-07_ses-meg_coordsystem.json sub-08/ses-meg/meg/sub-08_ses-meg_coordsystem.json sub-09/ses-meg/meg/sub-09_ses-meg_coordsystem.json sub-10/ses-meg/meg/sub-10_ses-meg_coordsystem.json sub-11/ses-meg/meg/sub-11_ses-meg_coordsystem.json sub-12/ses-meg/meg/sub-12_ses-meg_coordsystem.json sub-13/ses-meg/meg/sub-13_ses-meg_coordsystem.json sub-14/ses-meg/meg/sub-14_ses-meg_coordsystem.json sub-15/ses-meg/meg/sub-15_ses-meg_coordsystem.json sub-16/ses-meg/meg/sub-16_ses-meg_coordsystem.json",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "ds000117"
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
"chain": [],
"cmd": "sed -i -e 's/\\(.*IntendedFor.:.\\).*sub-0001\\//\\1/' sub-0001/meg/sub-0001_coordsystem.json",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "ds000246"
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
"chain": [],
"cmd": "sed -i -e 's/\\(.*IntendedFor\":.*\"\\).*sub-000.\\//\\1/' sub-0002/ses-0001/meg/sub-0002_ses-0001_coordsystem.json sub-0003/ses-0001/meg/sub-0003_ses-0001_coordsystem.json sub-0004/ses-0001/meg/sub-0004_ses-0001_coordsystem.json sub-0006/ses-0001/meg/sub-0006_ses-0001_coordsystem.json sub-0007/ses-0001/meg/sub-0007_ses-0001_coordsystem.json",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "ds000247"
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
"chain": [],
"cmd": "sed -i -e 's/\\(.*AssociatedEmptyRoom\":\"\\)\\//\\1/' sub-0002/ses-0001/meg/sub-0002_ses-0001_task-rest_run-01_meg.json sub-0003/ses-0001/meg/sub-0003_ses-0001_task-rest_run-01_meg.json sub-0004/ses-0001/meg/sub-0004_ses-0001_task-rest_run-01_meg.json sub-0006/ses-0001/meg/sub-0006_ses-0001_task-rest_run-01_meg.json sub-0007/ses-0001/meg/sub-0007_ses-0001_task-rest_run-01_meg.json sub-emptyroom/ses-18901014/meg/sub-emptyroom_ses-18901014_task-noise_run-01_meg.json sub-emptyroom/ses-18901015/meg/sub-emptyroom_ses-18901015_task-noise_run-01_meg.json sub-emptyroom/ses-18910228/meg/sub-emptyroom_ses-18910228_task-noise_run-01_meg.json sub-emptyroom/ses-18910303/meg/sub-emptyroom_ses-18910303_task-noise_run-01_meg.json sub-emptyroom/ses-18910512/meg/sub-emptyroom_ses-18910512_task-noise_run-01_meg.json",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "ds000247"
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
"chain": [],
"cmd": "sed -i -e 's/\\(.*IntendedFor\":.*\"\\).*sub-03\\//\\1/' sub-004/ses-1/sub-004_ses-1_task-FacePerception_coordsystem.json",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "eeg_ds003645s_hed_demo"
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
"chain": [],
"cmd": "sed -i -e '/.*IntendedFor.*/d' sub-004/ses-1/sub-004_ses-1_task-FacePerception_coordsystem.json",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "eeg_ds003645s_hed_demo"
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
"chain": [],
"cmd": "sed -i -e 's/\\(.*IntendedFor\":.*\"\\)\\//\\1/' sub-bp/ses-01/ieeg/sub-bp_ses-01_space-ACPC_coordsystem.json sub-bp/ses-01/ieeg/sub-bp_ses-01_space-Talairach_coordsystem.json sub-ca/ses-01/ieeg/sub-ca_ses-01_space-ACPC_coordsystem.json sub-ca/ses-01/ieeg/sub-ca_ses-01_space-Talairach_coordsystem.json sub-cc/ses-01/ieeg/sub-cc_ses-01_space-ACPC_coordsystem.json sub-cc/ses-01/ieeg/sub-cc_ses-01_space-Talairach_coordsystem.json sub-de/ses-01/ieeg/sub-de_ses-01_space-Talairach_coordsystem.json sub-fp/ses-01/ieeg/sub-fp_ses-01_space-Talairach_coordsystem.json sub-gc/ses-01/ieeg/sub-gc_ses-01_space-Talairach_coordsystem.json sub-hh/ses-01/ieeg/sub-hh_ses-01_space-Talairach_coordsystem.json sub-hl/ses-01/ieeg/sub-hl_ses-01_space-ACPC_coordsystem.json sub-hl/ses-01/ieeg/sub-hl_ses-01_space-Talairach_coordsystem.json sub-jc/ses-01/ieeg/sub-jc_ses-01_space-ACPC_coordsystem.json sub-jc/ses-01/ieeg/sub-jc_ses-01_space-Talairach_coordsystem.json sub-jm/ses-01/ieeg/sub-jm_ses-01_space-Talairach_coordsystem.json sub-jt/ses-01/ieeg/sub-jt_ses-01_space-Talairach_coordsystem.json sub-rh/ses-01/ieeg/sub-rh_ses-01_space-Talairach_coordsystem.json sub-rr/ses-01/ieeg/sub-rr_ses-01_space-Talairach_coordsystem.json sub-ug/ses-01/ieeg/sub-ug_ses-01_space-Talairach_coordsystem.json sub-wc/ses-01/ieeg/sub-wc_ses-01_space-ACPC_coordsystem.json sub-wc/ses-01/ieeg/sub-wc_ses-01_space-Talairach_coordsystem.json sub-zt/ses-01/ieeg/sub-zt_ses-01_space-ACPC_coordsystem.json sub-zt/ses-01/ieeg/sub-zt_ses-01_space-Talairach_coordsystem.json",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "ieeg_motorMiller2007"
}
^^^ Do not change lines above ^^^
effigies
force-pushed
the
fix/intended_fors
branch
from
8651125
to
3482666
Compare
effigies
added a commit
to bids-standard/legacy-validator
that referenced
this pull request
Apr 26, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am also submitting these fixes to the OpenNeuro dataset authors.
Leaving as draft until I get through all of the validator failures.
Closes bids-standard/legacy-validator#437.