Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add --prune option to prevent walking subtrees #124

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

effigies
Copy link
Contributor

This is an optimization to allow for raw datasets with extensive nested derivatives to be efficiently validated. It does not change the default behavior or performance characteristics.

This proactively prunes the filetree during construction, which can prevent many unnecessary stats and construction of many unnecessary objects. The primary downside is that this prevents recursive validation and including pruned files in the dataset size estimate.

Closes #115.

@effigies
Copy link
Contributor Author

I'm not sure if there's any value in performing a similar optimization for the web interface.

@effigies effigies force-pushed the fix/prune-subdatasets branch from dc535ee to d5cb385 Compare December 1, 2024 14:36
@rwblair rwblair merged commit a411f4c into bids-standard:main Dec 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal JavaScript out of memory: Ineffective mark-compacts near heap limit
2 participants