Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Permit electrodes.tsv in meg directories #1738

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

effigies
Copy link
Collaborator

Implements bids-standard/bids-specification#1555 for the legacy validator. RECOMMENDED status can wait on the schema.

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.32 ⚠️

Comparison is base (268a44e) 85.71% compared to head (4c58017) 83.40%.

❗ Current head 4c58017 differs from pull request most recent head 1bf8ca1. Consider uploading reports for the commit 1bf8ca1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1738      +/-   ##
==========================================
- Coverage   85.71%   83.40%   -2.32%     
==========================================
  Files         130       92      -38     
  Lines        6575     3893    -2682     
  Branches     1524     1270     -254     
==========================================
- Hits         5636     3247    -2389     
+ Misses        833      548     -285     
+ Partials      106       98       -8     

see 38 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@effigies effigies merged commit 6677c9a into bids-standard:master Aug 24, 2023
21 of 24 checks passed
@effigies effigies deleted the fix/meg_electrodes branch August 24, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants