Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to write validation results to file. #2131

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

rwblair
Copy link
Member

@rwblair rwblair commented Sep 9, 2024

Only works in Deno. Also makes black holing nifit library output less black holey.

Closes #829

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.54%. Comparing base (53fc889) to head (2381a3a).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
bids-validator/src/files/nifti.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2131      +/-   ##
==========================================
+ Coverage   85.72%   87.54%   +1.82%     
==========================================
  Files          91      133      +42     
  Lines        3782     7003    +3221     
  Branches     1220     1657     +437     
==========================================
+ Hits         3242     6131    +2889     
- Misses        454      777     +323     
- Partials       86       95       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit b174bb1 into bids-standard:master Sep 10, 2024
19 checks passed

if (options.outfile) {
if (globalThis.Deno) {
Deno.writeTextFileSync(options.outfile, output_string)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just curious - is writing to a file is a challenge in original Node???

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but it is a challenge in a browser. This code is currently ever only run by browsers and Deno.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I see -- it was not "deno vs legacy" (which is on my mind when "not deno") it was "deno vs in-browser"! Thank you @rwblair for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wishlist] -o|--output option to specify file to store output in
4 participants