Add option to write validation results to file. #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat/output_to_file I accidently commited changes to src/files/outfile.ts and src/setup/options.ts to this merge.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2131 +/- ##
==========================================
+ Coverage 85.72% 87.54% +1.82%
==========================================
Files 91 133 +42
Lines 3782 7003 +3221
Branches 1220 1657 +437
==========================================
+ Hits 3242 6131 +2889
- Misses 454 777 +323
- Partials 86 95 +9 ☔ View full report in Codecov by Sentry. |
nellh
approved these changes
Sep 9, 2024
yarikoptic
reviewed
Sep 13, 2024
|
|
||
| if (options.outfile) { | ||
| if (globalThis.Deno) { | ||
| Deno.writeTextFileSync(options.outfile, output_string) |
There was a problem hiding this comment.
I am just curious - is writing to a file is a challenge in original Node???
There was a problem hiding this comment.
No, but it is a challenge in a browser. This code is currently ever only run by browsers and Deno.
There was a problem hiding this comment.
ah, I see -- it was not "deno vs legacy" (which is on my mind when "not deno") it was "deno vs in-browser"! Thank you @rwblair for the explanation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only works in Deno. Also makes black holing nifit library output less black holey.
Closes #829