Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SAMRI, update BEP001 link #222

Merged
merged 6 commits into from
Jan 18, 2022
Merged

Conversation

sappelhoff
Copy link
Member

closes #220
closes #221

Comment on lines +235 to +241
- name: SAMRI
url: https://github.com/IBT-FMI/SAMRI
updated: 2021-11-08
data_types: small-animal MRI
language: Python, shell
documentation: https://doi.org/10.3389/fninf.2020.00005
GUI: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheChymera this PR adds the SAMRI converter to the list of bids compatible data converters/tools (see https://bids.neuroimaging.io/benefits.html#mri-and-pet-converters).

I filled in the info as well as I could from a brief glance --> could you please (by looking at the other entries in this YML file) add information that I missed, and/or correct what I got wrong?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sappelhoff thank you! I could help out with this, but I can't really understand where/why the markdown link check fails :-/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it by removing it :) ... was some link in an old blog post that nobody is going to miss.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but your help would be appreciated by either approving of the changes ... or telling me which additional info I should include.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL does still resolve... https://journals.sagepub.com/doi/10.1177/0271678X20905433. May have been a temporary failure?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair point, I added it back and changed the link to be a proper doi.org link instead of the sagepub link. Although it might just redirect there anyways.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure may be related to tcort/markdown-link-check#109.

Copy link
Contributor

@TheChymera TheChymera Jan 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sappelhoff should I just write a comment here for what's to be added, or submit a PR to your branch? I think it might be easiest if I just submit a PR for additional info after this is merged.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheChymera sounds good - looking forward to your follow-up PR to improve the information!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#224 for the follow-up :)

@sappelhoff sappelhoff merged commit 23a6bed into bids-standard:gh-pages Jan 18, 2022
@sappelhoff sappelhoff deleted the updates branch January 18, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update link to BEP001 Add SAMRI to list of converters
3 participants