Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON schema: iEEG if Coordsystem "Pixels", Unit must be "pixels" #1148

Closed
sappelhoff opened this issue Jan 15, 2021 · 0 comments · Fixed by #1189
Closed

JSON schema: iEEG if Coordsystem "Pixels", Unit must be "pixels" #1148

sappelhoff opened this issue Jan 15, 2021 · 0 comments · Fixed by #1189
Labels
effort: medium Estimated medium effort task iEEG impact: low Estimated low impact task json-schema All issues that involve work with the JSON-schema files

Comments

@sappelhoff
Copy link
Member

sappelhoff commented Jan 15, 2021 •
edited
Loading

https://bids-specification.readthedocs.io/en/stable/04-modality-specific-files/04-intracranial-electroencephalography.html#coordinate-system-json-_coordsystemjson

Currently, users could specify the iEEGCoordinateSystem to be Pixels, but then specify a unit that's mm, cm, m, or pixels.

Only pixels should be valid according to the specification.

see also: bids-standard/bids-specification@76b5b22
@sappelhoff sappelhoff added iEEG json-schema All issues that involve work with the JSON-schema files labels Jan 15, 2021
@sappelhoff sappelhoff added effort: medium Estimated medium effort task impact: low Estimated low impact task labels Feb 2, 2021
sappelhoff added a commit to sappelhoff/bids-validator that referenced this issue Feb 13, 2021
@sappelhoff
ENH: when iEEG coordsys is Pixels, validate units to be pixels
c79d4de 
closes bids-standard#1148
@sappelhoff sappelhoff mentioned this issue Feb 13, 2021
Merged
sappelhoff added a commit that referenced this issue Feb 15, 2021
@sappelhoff
ENH: when iEEG coordsys is Pixels, validate units to be pixels (#1189)
4c1be20 
closes #1148
rob-luke pushed a commit to rob-luke/bids-validator that referenced this issue Jan 31, 2022
@sappelhoff @rob-luke
ENH: when iEEG coordsys is Pixels, validate units to be pixels (bids-…
7b6d721 
…standard#1189)

closes bids-standard#1148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: medium Estimated medium effort task iEEG impact: low Estimated low impact task json-schema All issues that involve work with the JSON-schema files
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: when iEEG coordsys is Pixels, validate units to be pixels sappelhoff/bids-validator
1 participant
@sappelhoff