Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEPOLAR fieldmaps throwing code 90 (SIDECAR_WITHOUT_DATAFILE) when part-<value> is present #1882

Closed
oesteban opened this issue Jan 24, 2024 · 4 comments · Fixed by #1884
Closed

Comments

@oesteban
Copy link
Contributor

I assume that, as a result of bids-standard/bids-specification#1684, the validator throws:

[ERR] A json sidecar file was found without a corresponding data file (code: 90 - SIDECAR_WITHOUT_DATAFILE)

Sidecar: ./sub-001/ses-001/fmap/sub-001_ses-001_acq-bold_dir-AP_epi.json

When the corresponding two NIfTI files exist:

./sub-001/ses-001/fmap/sub-001_ses-001_acq-bold_dir-AP_part-mag_epi.nii.gz
./sub-001/ses-001/fmap/sub-001_ses-001_acq-bold_dir-AP_part-phase_epi.nii.gz

Please let me know if I'm wrong on this expectation.

@oesteban
Copy link
Contributor Author

Since bids-standard/bids-specification#1684 is now merged, propagating the changes here implies just updating the rules at top, session and file levels?

@effigies
Copy link
Collaborator

It's always possible that there's a corner case in constructing a sidecar/data file mapping, so it's worth testing.

@oesteban
Copy link
Contributor Author

do you mean that some test should be added? If that is the case, is there anything you can point me at to get started without bugging you?

@effigies
Copy link
Collaborator

Probably, but I would have to dig to figure out what to suggest. I was thinking at the least you could use your dataset that's currently failing to test your patch. There's a Dockerfile in case a local node setup is a pain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants