Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading this: https://tokbox.com/developer/sdks/ios/
Noticed this comment:
It's not totally clear what FAT binaries are but snooping with Dad we hacked the cordova-ios package to force the entire build to use
EXCLUDED_ARCHS[sdk=iphonesimulator*] = arm64
and it worked but felt wrong. So we were thinking that maybe the entire problem was that OpenTok 2.24.2 was forcing everyone else to exclude arm64 from the simulator which felt bad.Reading lots of ambiguous articles on the internet about whether the simulator supported ARM64 was unclear but when we successfully launched a fully ARM64 app just be omitting OpenTok it seemed like OpenTok was the problem. So we hunted around and found CocoaPods/cocoapods.org#454 which pretty clearly implied there was another Cocoapod for OpenTok of a different sort.
So we tried this change and everything builds and launches correctly when you modify bw_phonegap like so
Tomorrow I want to do a build of some app and fully test using Tokbox streaming. I will need some help learning how to do that. Dad suggested that maybe we do a new release of BWStaging app with this latest code and Testflight...
Going forward he also said that we can stop doing releases to npmjs.org and can instead just reference the github repo like above (NOTE: when we merge this we can drop
#otxcframework
since we will just reference the master branch). Dad says, the reason we needed to do npmjs.org releases previously was because Phonegap Build didn't have access to repos besidesbw_phonegap
so it could only fetch packages from npmjs.org. Since we're no longer using that service and are building locally with fastlane/Xcode as a developer that has github access we don't need fully released packages anymore.So... I think the todo list is something like this: