Add edit fund interface & Some fix (#457)

* Add edit fund interface & Some fix * Remove unused codes
bifrost-io · Dec 27, 2021 · 63ac67f · 63ac67f
1 parent 1fe2659
commit 63ac67f
Show file tree

Hide file tree

Showing 4 changed files with 80 additions and 2 deletions.
diff --git a/pallets/salp-lite/src/lib.rs b/pallets/salp-lite/src/lib.rs
@@ -689,6 +689,46 @@ pub mod pallet {
 
 			Ok(())
 		}
+
+		/// Edit the configuration for an in-progress crowdloan.
+		///
+		/// Can only be called by Root origin.
+		#[pallet::weight((
+			0,
+			DispatchClass::Normal,
+			Pays::No
+			))]
+		pub fn edit(
+			origin: OriginFor<T>,
+			#[pallet::compact] index: ParaId,
+			#[pallet::compact] cap: BalanceOf<T>,
+			#[pallet::compact] raised: BalanceOf<T>,
+			#[pallet::compact] first_slot: LeasePeriod,
+			#[pallet::compact] last_slot: LeasePeriod,
+			fund_status: Option<FundStatus>,
+		) -> DispatchResult {
+			T::EnsureConfirmAsGovernance::ensure_origin(origin)?;
+
+			let fund = Self::funds(index).ok_or(Error::<T>::InvalidParaId)?;
+
+			let status = match fund_status {
+				None => fund.status,
+				Some(status) => status,
+			};
+			Funds::<T>::insert(
+				index,
+				Some(FundInfo {
+					cap,
+					first_slot,
+					last_slot,
+					status,
+					raised,
+					trie_index: fund.trie_index,
+				}),
+			);
+			Self::deposit_event(Event::<T>::Edited(index));
+			Ok(())
+		}
 	}
 
 	#[pallet::hooks]

diff --git a/pallets/salp-lite/src/tests.rs b/pallets/salp-lite/src/tests.rs
@@ -866,3 +866,25 @@ fn refund_meanwhile_issue_should_work() {
 		assert_noop!(Salp::redeem(Some(BRUCE).into(), 3_000, 50), Error::<Test>::InvalidParaId);
 	});
 }
+
+#[test]
+fn edit_fund_should_work() {
+	new_test_ext().execute_with(|| {
+		assert_ok!(Salp::create(Some(ALICE).into(), 3_000, 1_000, 1, SlotLength::get()));
+		assert_ok!(Salp::issue(Some(ALICE).into(), BRUCE, 3_000, 100, CONTRIBUTON_INDEX));
+		assert_ok!(Salp::fund_fail(Some(ALICE).into(), 3_000));
+
+		assert_ok!(Salp::edit(
+			Some(ALICE).into(),
+			3_000,
+			1_000,
+			150,
+			2,
+			SlotLength::get() + 1,
+			Some(FundStatus::Ongoing)
+		));
+		let fund = Salp::funds(3_000).unwrap();
+		assert_eq!(fund.raised, 150);
+		assert_eq!(fund.status, FundStatus::Ongoing);
+	});
+}
diff --git a/pallets/salp/src/lib.rs b/pallets/salp/src/lib.rs
@@ -464,6 +464,7 @@ pub mod pallet {
 			origin: OriginFor<T>,
 			#[pallet::compact] index: ParaId,
 			#[pallet::compact] cap: BalanceOf<T>,
+			#[pallet::compact] raised: BalanceOf<T>,
 			#[pallet::compact] first_slot: LeasePeriod,
 			#[pallet::compact] last_slot: LeasePeriod,
 			fund_status: Option<FundStatus>,
@@ -484,7 +485,7 @@ pub mod pallet {
 					first_slot,
 					last_slot,
 					status,
-					raised: fund.raised,
+					raised,
 					trie_index: fund.trie_index,
 				}),
 			);
@@ -792,6 +793,8 @@ pub mod pallet {
 
 			fund.raised = fund.raised.saturating_sub(contributed);
 
+			Funds::<T>::insert(index, Some(fund.clone()));
+
 			T::MultiCurrency::slash_reserved(vsToken, &who, contributed);
 			T::MultiCurrency::slash_reserved(vsBond, &who, contributed);
 
@@ -853,6 +856,8 @@ pub mod pallet {
 				}
 			}
 
+			Funds::<T>::insert(index, Some(fund));
+
 			if all_refunded {
 				Self::deposit_event(Event::<T>::AllRefunded(index));
 			}
@@ -901,6 +906,7 @@ pub mod pallet {
 			}
 
 			fund.raised = fund.raised.saturating_sub(value);
+			Funds::<T>::insert(index, Some(fund.clone()));
 
 			if T::TransactType::get() == ParachainTransactType::Xcm {
 				T::MultiCurrency::transfer(

diff --git a/pallets/salp/src/tests.rs b/pallets/salp/src/tests.rs
@@ -1195,20 +1195,30 @@ fn edit_fund_should_work() {
 			CONTRIBUTON_INDEX
 		));
 		assert_ok!(Salp::fund_fail(Some(ALICE).into(), 3_000));
-		assert_ok!(Salp::edit(Some(ALICE).into(), 3_000, 1_000, 2, SlotLength::get() + 1, None));
+		assert_ok!(Salp::edit(
+			Some(ALICE).into(),
+			3_000,
+			1_000,
+			200,
+			2,
+			SlotLength::get() + 1,
+			None
+		));
 		let mut fund = Salp::funds(3_000).unwrap();
 		assert_eq!(fund.first_slot, 2);
 		assert_eq!(fund.status, FundStatus::Failed);
 		assert_ok!(Salp::edit(
 			Some(ALICE).into(),
 			3_000,
 			1_000,
+			200,
 			2,
 			SlotLength::get() + 1,
 			Some(FundStatus::Ongoing),
 		));
 		fund = Salp::funds(3_000).unwrap();
 		assert_eq!(fund.status, FundStatus::Ongoing);
+		assert_eq!(fund.raised, 200);
 	})
 }