Fix a potential bug about ChargedPoolIds #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ark930
approved these changes
Nov 11, 2021
ark930
pushed a commit
that referenced
this pull request
Mar 13, 2022
ark930
added a commit
that referenced
this pull request
Mar 28, 2022
* Refactor primitives (#171) * remove unused types * move test cases into tests.rs * fix * remove unused types * update chain spec (#172) * update chain spec * fix * remove unused pallets (#173) * vsbond-auction-fix (#174) * 🐛 ($PALLET) Fix vsbond lock error * 🎨 ($PALLET) Format code * ✅ ($PALLET) Refactor vsbond-auction unit-tests * ✅ ($PALLET) Add new unit-test * Improve image build (#175) * Improve ci * Fix codacy * [skip ci] [skip ci] * Remove bifrost asset (#176) * Refactor docs (#177) * move eos related files under eos directory * update * update readme resources * Fix build image (#180) * companion for polkadot-v0.9.8 (#178) * companion for polkadot-v0.9.8 * fix test * Benchmarks runtime integration (#181) * Fix build image * Benchmark runtime integration * Xcm test framework (#182) * Xcm test framework * fix * Herry optimize (#183) * optimize vtoken-mint module * refactor minter-reward module and related vtoken-mint related functions * refactor mint-reward module * refactor * refactor * refactor * Fix build image from ci (#184) * rename charge-transaction-fee module to flexible-fee (#185) * - change the name of charge-transaction-fee module to flexible fee - add a add tokens function for sudo in Bancor module * cargo +nightly fmt --all * Refactor salp (#179) * 🚧 ($PALLET) Refactor salp - contribute & contribution * 🚧 ($PALLET) Refactor withdraw * 🚧 ($PALLET) Add refund-pool * 🚧 ($PALLET) Refactor salp - delete redeem-pool * 🚧 ($PALLET) Refactor salp - delete useless code * 🚧 ($PALLET) Refactor salp - fix compile error * ✅ ($PALLET) Add/Update/Remove unit-tests * ✅ ($PALLET) Add the unit-tests of refund * 🐛 ($PALLET) Fix bug on refund * ✨ ($PALLET) Refund can be called again after last refund is over * ♻️ ($PALLET) Refactor contribution for auto unlock * 🚧 ($PALLET) Refactor salp - refact redeem * ♻️ ($PALLET) Complete the refactor of redeem * 🎨 ($PALLET) Format salp * 🐛 ($PALLET) Fix the potential bug in refund-pool&redeem-pool * ✨ ($PALLET) Add unlock function * 🎨 ($PALLET) Format code * 🐛 ($PALLET) Add check for the balance of redeem-pool * ✅ ($PALLET) Add the unit-tests of unlock&redeem * 🐛 ($PALLET) Fix the bug of release from redeem to bancor * ✅ ($PALLET) Add unit-tests for Hooks * 🎨 ($PALLET) Format code * 🔧 ($PALLET) Move dependencies * 🔥 ($PALLET) Remove unused config * 🚑 ($PALLET) Quick fix mock error * minor fix Co-authored-by: Edwin Wang <lark930@gmail.com> * vsbond-auction - support decimal price (#186) * 🎨 ($PALLET) Adjust code * 🐛 ($PALLET) Fix compile error * 🔧 ($PALLET) Update dependencies * ✨ ($PALLET) Support decimal * 🎨 ($PALLET) Format code * Fix token types (#187) * fix token types * fix * ♻️ ($PALLET) Finish salp * remove assets from Cargo.toml Co-authored-by: Allen Pocket <AllenPocketGamer@Gmail.com> * Update rustfmt (#189) * 🔧 ($ROOT) Update rustfmt.toml * 🎨 ($ALL) Reformat code * 🚧 ($ROOT) Update Cargo.lock * feat: 🎸 add a macro to convert between currencyid and assetid (#188) * feat: 🎸 add a macro to convert between currencyid and assetid * fix: 🐛 fix cargo check * fix: 🐛 change the discriminant value of enum * Modify bancor (#190) * - modity add_token_to_pool call to support initial token adding by any account who has enough token balance. - add functionalities to on_initialize hook to release certain amount of token by every block. * cargo +nightly fmt --all * cargo +nightly fmt --all * Salp Revamp companion for dmp transfer (#191) * Salp Revamp companion for dmp transfer * Fix check * fix: 🐛 add bootnode to bifrost.json (#192) * fix: 🐛 add bootnode to bifrost.json * fix: 🐛 change bootnode * Readme improvement (#193) * Fix benchmarking&CI integration (#194) * No longer exposed unit_price to front-end (#195) * ♻️ ($PALLET) No longer exposed unit_price to front-end * 🎨 ($PALLET) Format the code * Ksm fee (#197) * swap Native CurrencyId index(2) to index(0) with Token CurrencyId * - Fix Flexible Fee Module unit tests - Wrap ensure_can_charge_fee function into FeeDealer trait * fix runtime errors caused by native currencyId index change * unitests done with flexible-fee module * cargo +nightly fmt --all * Alert monitoring (#198) * Add development runtime (#200) * remove pallet bridge (#201) * Add rules for parachain (#202) * add bancor benchmarking file (#203) * bancor add_token_to_pool benchmarking functionality * Fix benchmarking&CI integration * add bancor module benchmarking * fixes Co-authored-by: ron.yang <yrong1997@gmail.com> * modify flexible-fee module to charge KSM only in the situation of insufficient BNC (#204) * - fix bancor missing 2 rpc interfaces (#207) * - fix bancor missing 2 rpc interfaces - fix the benchmarking bugs caused by asgard-dev runtime being changed to dev runtime * Fix benchmark build Co-authored-by: ron.yang <yrong1997@gmail.com> * Add manual-sealing consensus for dev runtime (#208) * Add manual-sealing consensus for dev runtime * Add script in makefile * Build wasm script (#209) * Add script for pm2 deployment (#206) * Local docker deployment (#205) * Local docker deployment Add local docker deployment with parachain launch Expose data volumn with name `data` * Fix codacy check * Use light container as builder * Fix build image[skip ci] (#210) * update readme intro (#212) * update readme intro * fix the error * fix bug in minter reward module (#214) * docs: ✏️ Run full node with docker (#216) * More benchmarking (#217) * add flexible-fee benchmarking * vtoken-mint benchmarking * add flexible-fee benchmarking * vtoken-mint benchmarking * Minter-reward moudle: change auto depositing reward to user claiming reward * minter-reward benchmarking part1 * finish minter reward benchmarking * fix according to comments * Bifrost v0.8.1 (#220) * disable on_runtime_upgrade in vesting * bump version to 0.8.1 * Bump substrate (#213) * Fix build image[skip ci] (#210) * update readme intro (#212) * update readme intro * fix the error * Bump substrate Co-authored-by: wodlj1314 <72777624+wodlj1314@users.noreply.github.com> * make MinVestedTransfer equal to ExistentialDeposit * Bump version for cumulus * fix types mismatch * fix types mismatch * fix vest start at * fix Co-authored-by: yrong1997 <yrong1997@gmail.com> Co-authored-by: wodlj1314 <72777624+wodlj1314@users.noreply.github.com> * Try-runtime integration (#221) > Integate with command cli and runtime hooks > Refact to use macro `with_runtime_or_err` > Add entrance script > Upate readme accordingly * Add tokens and currencies (#211) * add orml tokens and currencies pallets to Bifrost Runtime * add Currency::LPToken and modify currency to index conversion method * add Currency LPToken * add call filter for Tokens and Currencies modules in Bifrost runtime * Fix build image[skip ci] (#210) * update readme intro (#212) * update readme intro * fix the error * fix bug in minter reward module (#214) * docs: ✏️ Run full node with docker (#216) * More benchmarking (#217) * add flexible-fee benchmarking * vtoken-mint benchmarking * add flexible-fee benchmarking * vtoken-mint benchmarking * Minter-reward moudle: change auto depositing reward to user claiming reward * minter-reward benchmarking part1 * finish minter reward benchmarking * fix according to comments * Bifrost v0.8.1 (#220) * disable on_runtime_upgrade in vesting * bump version to 0.8.1 * Bump substrate (#213) * Fix build image[skip ci] (#210) * update readme intro (#212) * update readme intro * fix the error * Bump substrate Co-authored-by: wodlj1314 <72777624+wodlj1314@users.noreply.github.com> * make MinVestedTransfer equal to ExistentialDeposit * Bump version for cumulus * fix types mismatch * fix types mismatch * fix vest start at * fix Co-authored-by: yrong1997 <yrong1997@gmail.com> Co-authored-by: wodlj1314 <72777624+wodlj1314@users.noreply.github.com> * Try-runtime integration (#221) > Integate with command cli and runtime hooks > Refact to use macro `with_runtime_or_err` > Add entrance script > Upate readme accordingly * add orml tokens and currencies pallets to Bifrost Runtime * add Currency::LPToken and modify currency to index conversion method * add Currency LPToken * add call filter for Tokens and Currencies modules in Bifrost runtime * delete deref implementation for currencyid * format * format Co-authored-by: yrong1997 <yrong1997@gmail.com> Co-authored-by: wodlj1314 <72777624+wodlj1314@users.noreply.github.com> Co-authored-by: Yu <ymlll0508@gmail.com> Co-authored-by: Edwin <lark930@gmail.com> * vsbond-acution benchmarking (#222) * add flexible-fee benchmarking * vtoken-mint benchmarking * Minter-reward moudle: change auto depositing reward to user claiming reward * vtoken-mint benchmarking * minter-reward benchmarking part1 * finish minter reward benchmarking * vsbond_auction benchmarking * smal fixes * add flexible-fee benchmarking * vtoken-mint benchmarking * Minter-reward moudle: change auto depositing reward to user claiming reward * vtoken-mint benchmarking * minter-reward benchmarking part1 * finish minter reward benchmarking * vsbond_auction benchmarking * smal fixes * small fixes * Xcm revamp about buy weight for transact (#223) * feat: 🎸 add Treasury and Bounties at bifrost runtime (#224) * feat: 🎸 add Treasury and Bounties at bifrost runtime * style: 💄 modify Cargo.toml format * change ausd to kusd (#225) * change ausd to kusd * feat: 🎸 add Treasury and Bounties at bifrost runtime (#224) * feat: 🎸 add Treasury and Bounties at bifrost runtime * style: 💄 modify Cargo.toml format * change ausd to kusd * resolve conflicts * cargo +nightly fmt --all * TokenSymbol description change from Acala dollar to Karura dollar Co-authored-by: Yu <ymlll0508@gmail.com> * Force set vested (#228) * add fn force_set_vested * change vesting to bifrost-vesting * remove fn force_set_vest_works * allow local test for manual seal * feat: 🎸 add bifrost.weights (#226) * feat: 🎸 add bifrost.weights * fix: 🐛 cargo +nightly fmt * Update orml dependencies (#230) * update orml dependencies * fix tests * Bifrost v0.8.2 (#231) * bump spec_version * bump native version * fix benchmark * refactor orml_tokens * update weights * add vesting into benchmarks * update pallet_vesting.rs * handle Result * cargo +nightly fmt * Enable dmp transfer (#232) * add orml-xtokens (#233) * Add kar (#234) * fix bug for TokenSymbol BNC interchaning with zenlink AssetId * change ASG in bifrost runtime to BNC * add kar and testing * fix bug for TokenSymbol BNC interchaning with zenlink AssetId * add kar and testing * Develop Liquidity-mining pallet (#199) * 🎉 ($PALLET) Init liqudity-mining * 🚧 ($PALLET) Basic framework * 🚧 ($PALLET) Add hook * 💚 ($PALLET) Refactor the structure and define the calculation * ✨ ($PALLET) Impl function: create mining pool * ✨ ($PALLET) Impl function: create farming pool & Complete events * ✨ ($PALLET) Complete the functions about liquidity-pool * 🚧 ($PALLET) Refactor code & define the corner conditions * 🚧 ($PALLET) Impl claim * 🚧 ($PALLET) Impl helper functions * 🚧 ($PALLET) Docs & Fix & Impl * 🎉 ($PALLET) Compl all extrinsics * ✅ ($PALLET) Impl mock * 🎨 ($PALLET) Rename activated to approved, init to under_audit * 🚧 ($PALLET) CodeFix & First UT & Adjust Mock * 🚧 ($PALLET) CodeFix & UT & MockAdjust * ✅ ($PALLET) Compl some tests * ✨ ($PALLET) Try to delete useless storage items * 🐛 ($PALLET) Limit the number of pool approved * ✅ ($PALLET) Compl some unit-tests * ✨ ($PALLET) Access LpToken * 🐛 ($PALLET) Fix the wrong reward calculation * ✅ ($PALLET) Compl deposit unit-tests * ✅ ($PALLET) More unit-tests * 🐛 ($PALLET) Fix divide zero error * 🐛 ($PALLET) Fix the bugs of redeem * ✅ ($PALLET) Compl redeem unit-tests * 🚧 ($PALLET) Fix & Refactor & Docs * ✅ ($PALLET) Compl all unit-tests * 🚀 ($PALLET) Intergate liquidity-mining to asgard * 🔥 ($PALLET) Remove useless code Co-authored-by: Edwin <lark930@gmail.com> * Salp revamp with multisig account to confirm (#227) * Salp revamp with multisig account to confirm * Fix ensureOrigin with multisig account * refact mock to use multisig * 🐛 ($PALLET) Fix liquidity-mining mock error (#237) * Revamp salp xcm weight (#236) * fixes for xcm conversion of KAR and KUSD (#238) * fix KAR, KUSD xcm conversion * fix KAR, KUSD xcm conversion * small fixes * small fixes * Merge branch 'develop' into weights (#235) * Enable democracy (#239) * Fix fee (#240) * Fee charge ksm directly (#241) * raw completement * done with unitesting * small fix * Adjust gov params (#244) * adjust governance parameters * adjust order * adjust treasury stuff (#245) * add flexible-fee module to Bifrost runtime (#247) * raw completement * done with unitesting * small fix * fix ksm flexible fee rpc * smal fix * add flexible-fee module to Bifrost runtime * change ASG to BNC * fixes * add FeeMultiplierUpdate (#249) * Revamp salp origin (#242) * Revamp salp origin * Revamp salp with proxy * Opt flexible fee (#251) * change defult fee order list * optimize flexible fee code * Opti liquidity-mining (#243) * ♻️ ($PALLET) Replace gain_avg from U64F64 to FixedU128 * 🚧 ($PALLET) Move mutation to the end of extrinsic * ✅ ($PALLET) Add simple integration test * ✨ ($PALLET) Add extrinsic: force_retire_pool * ✅ ($PALLET) Unit-tests for force_retire_pool * 🚧 ($PALLET) Fix bug & Add feature: volunteer_to_redeem * ✅ ($PALLET) Fix unit-tests & Add new unit-test * ✅ ($PALLET) Add unit-tests of volunteer_to_redeem * ✅ ($PALLET) Richer unit-tests * ✨ ($PALLET) EBF & Forbid claiming from pool-retired * ✅ ($PALLET) Fix unit-tests * ✅ ($PALLET) Compl unit-tests for early-bird farming * Bifrost V0.8.3 (#246) * allow transfer of all tokens except native token * bump version to 0.8.3 * enable transaction payment * update benchmark * Disable election * Salp with derivate (#250) * Revamp salp with derivated account * Fix:reserve ksm before confirm * Revamp with derivated proxy * Bump dependencies of Cumulus to polkadot-v0.9.9 (#253) * Bump from polkadot-v0.9.8 to polkadot-v0.9.9 * fixes * fix prometheus port of relay chain * fix-zenlink-upgrade-tests (#254) * Fix zenlink upgrade tests (#255) * fix-zenlink-upgrade-tests * fix bug of conversion from u64 to CurrencyId * fixes Co-authored-by: Herry Ho <45537372+herryho@users.noreply.github.com> * merge from v0.8.3 into develop (#256) * disable treasury burn (#257) * fix bad mandatory error (#258) * Salp with rpc (#252) * Revamp salp with derivated account * Fix:reserve ksm before confirm * Revamp with derivated proxy * Salp rpc integration * Revamp for confirm service * 🚑 ($RUNTIME) Change SalpTransactionType * fix: 🐛 fix ConfirmMuitiSigAccount * Add some nonce to amount as workround * Increase contribute weight to cover the nonce * Revamp for confirm service * Revamp transfer fee * Companion with v0.9.9 * 🐛 ($PALLET) Replace from +-*/ to saturating_* * Refact per discussion * fix test * fix test * Refact&Clean * Fix build * Refact&Clean&Fix tests * 🐛 ($PALLET) Fix bug & Fix tests & Fix mock * Integrate salp into bifrost runtime Co-authored-by: Allen Pocket <AllenPocketGamer@Gmail.com> Co-authored-by: Edwin Wang <lark930@gmail.com> Co-authored-by: yooml <ymlll0508@gmail.com> * feat: 🎸 add pallet_multisig (#261) * Add xtokens to Bifrost runtime (#260) * small fixes * small fixes * make native(TokenSymbol::ASG) into Token(TokenSymbol::ASG) before transferred to Karura * currencyId encode mapping * xtokens transfer works * add xtokens pallet to Bifrost runtime * add orml unknown tokens module * add support for kusd * fix test * SALP optimization (#262) * remove unused types * 🔥 ($PALLET) Remove useless code * remove unused types Co-authored-by: Allen Pocket <AllenPocketGamer@Gmail.com> * Refact collator (#263) * Refact collator * pin toolchain * 📝 ($PALLET) Add docs to vsbond-auction (#264) * fix KAR\KUSD existential deposit (#265) * Fix salp rpc (#270) * Fix salp rpc * Fix with pinned rust toolchain * add multiple fee traders (#271) * fix BNC as xcmp fee currency (#274) * add multiple fee traders * fix bnc as xcmp currency fee * fix Bancor rpc for returning value as NumberOrHex (#275) * Fix break benchmark&Update weight (#273) * 🚑 ($RUNTIME) Change Salp::MinContribution to 0.1KSM at Bifrost (#278) * Revamp salp fee (#279) * add-orml-xcm (#280) * Revamp salp origin (#283) * add-endowment-in-bifrost-test-chainspec (#284) * add-endowment-in-bifrost-test-chainspec * remove faucet_accounts * remove unsupported tokens Co-authored-by: Edwin Wang <lark930@gmail.com> * fix KUSD type to CurrencyId::Stable (#286) * fix KUSD in develop branch (#288) * Charge salp transaction fee (#289) * done without unit testing * add salp mock to flexible fee module * charge salp fee in flexible fee module done with unit testing * add salp fee to bifrost runtime * fixt-tests * Revamp salp rpc (#290) * Revamp salp rpc * Revamp per flexible-fee&some fix * minor fix * Change SALP multisig account (#291) * change SALP multisig account * cargo +nightly fmt * fix compact error (#292) * fix () implementation for trait BancorHandler (#293) * delete bancor for bifrost runtime (#294) * Bump v0.9.0 (#295) * bump version to v0.9.0 * remove sudo * cargo +nightly fmt * cargo +nightly fmt * cargo +nightly fmt * Revamp salp with fund edit (#296) * Revamp&Fix in salp (#298) * Revamp&Fix in salp * Fix per discussion * Fix with bancor return error instead * add alice to council and tech committee (#301) * Refactor vsbond auction (#300) * ♻️ ($PALLET) Refactor vsbond-auction: 1/3 * ♻️ ($PALLET) Switch from U64F64 to FixedU128: 2/3 * 🐛 ($PALLET) Fix bug on partial_clinch_order * 🔥 ($PALLET) Remove order state * ✅ ($PALLET) Fix test * ✅ ($PALLET) Compl tests * 🐛 ($PALLET) Unreserve the remain price of buy order * ✅ ($PALLET) Add unit-tests * 🎨 ($PALLET) Format code * 🐛 ($RUNTIME) Change the constant name * 🐛 ($PALLET) Fix .. * Revamp ci&image flow (#304) * Revamp ci&image flow * Zenlink dependency as forked * Refactor liquidity mining (#302) * ♻️ ($PALLET) Quick refactor * 🎨 ($PALLET) Rename Approved to Charged * 🐛 ($RUNTIME) Fix liquidity-mining config on runtime * 🎨 ($PALLET) Switch approved to charged * ✅ ($PALLET) Fix unit-tests * 🏗️ ($RUNTIME) Integrate liquidity-mining to bifrost * 🔧 ($RUNTIME) Upgrade MaximumCharged from 8 to 32 * ✅ ($PALLET) Add a new test * add ZLK (#303) * add ZLK * change bifrost runtime and native version to 0.9.1 * fix ZLK existential deposit amount * Modify lm reviewed (#307) * ♻️ ($PALLET) Modify after review * 🔧 ($RUNTIME) Modify lm configs * 🔧 ($RUNTIME) Add LiquidityMining Pallet to Dust White List * ✨ ($PALLET) Add limit on option rewards number * 🔧 ($PALLET&Runtime) Change Config on runtime & Fix a bug * opt bifrost_local chainspec (#306) * Salp improve (#305) * Remove can_redeem check&Fix contribution storage * Support batch refund * Fix xcm test * Fix per review comments * Integration test (#282) * Integration test framework&Refact codes * Some minor fix * minor fix * Fix merge * Remove constant refact * Fix xcm test * Fix build fail * Add benchmarking to lm (#309) * 🚧 ($PALLET) Add benchmarking and weights to lm * 💡 ($PALLET) Add docs on `PoolType` * ✨ ($PALLET) Discard the weights of sudo extrinsics * 🐛 ($PALLET) Fix salp & vsbond-auction benchmarking code * 🎨 ($PALLET) Rename T to Test * 🚧 ($PALLET) Upgrade.. * 🚧 ($PALLET) Compl benchmarking * 🐛 ($PALLT) Fix some errs * allow vsksm and vsbond transferring (#310) * Add lm weights to bifrost runtime (#311) * 🐛 ($PALLET) Fix err when running benchmarks * 🎨 ($PALLET) Reformat code * ✨ ($PALLET) Add weights to lm * benchmark for liquidity mining (#313) * Modify lm redeem (#314) * ✨ ($PALLET) Add option value to redeem * ✅ ($PALLET) Cover unit-tests on last modification * 🐛 ($PALLET) Fix benchmarks after modification * ✨ ($PALLET) Add redeem_all * ✅ ($PALLET) Cover unit-tests * 🐛 ($PALLET) Fix benchmark and weights * Fix lm bug (#315) * 🐛 ($PALLET) Fix deposit lock bug * ✅ ($PALLET) Fix unit-tests * Liquidity mining benchmark (#316) * benchmark for liquidity mining * update README.md * Benchmark for salp (#317) * benchmark for salp * Fix benchmark Co-authored-by: yrong1997 <yrong1997@gmail.com> * Add rpc for lm (#318) * ✨ ($PALLET) Add lm rpc to bifrost * 🍻 ($PALLET) Compl rpc for lm * 🐛 ($PALLET) Fix compile error * 🐛 ($PROJ) Upgrade Cargo.lock (#319) * Fix dust white list (#320) * 🐛 ($PALLET) Fix dust white list * 🎨 ($PALLET) Format code * vsksm crosschain support (#312) * Refactor Asgard runtime (#322) * Token issuer (#321) * token-issuer * fixes * bump zenlink (#323) * bump zenlink (#324) * zenlink lptoken (#325) * fix: 🐛 modify ControlOrigin of liquidity_mining (#329) * feat: 🎸 add zenlink to bifrost (#330) * Update deps to polkadot-v0.9.10 (#328) * Update deps to polkadot-v0.9.10 * format * format * fix test for bifrost-salp * fix test for bifrost-flexible-fee * fix test for runtime-dev * fix Cargo.toml * cargo fmt * Refact xcm call&Companion with v0.9.10 * fix zenlink * Refact xcm adaptor Co-authored-by: yrong1997 <yrong1997@gmail.com> * Add token issuer benchmarking (#331) * add token-issuer benchmarking to asgard runtime * add token issuer benchmark to bifrost runtime * fix version bug * Fix integration test (#332) * add zenlink rpc (#333) * update rust toolchain to nightly-2021-09-12 (#334) * Bump version to v0.9.2 (#336) * bump version to v0.9.2 * cargo +nightly fmt * Fix lm reward settlement (#335) * ✨ ($PALLET) Discard the reward lower than ed * ✅ ($PALLET) Add test for the repair of last commit * 🐛 ($PALLET) Fix the bug produced by last fix * ✅ ($PALLET) Make unit-test more complete * Fix lm force retire (#337) * 🐛 ($PALLET) Fix the bug of `force_retire_pool` * ✅ ($PALLET) Modify unit-test to cover bug range * unit tests done (#327) * unit tests done * add lightening-redeem benchmarking to asgard runtime * change LighteningRedeemPalletId * minor fix (#339) * delete multiweighttraders (#340) * Allow token transfer except BNC and ZLK (#341) * 🚑 ($PALLET) Discard remain reward be less than ed (#344) * Allow BNC transfer and enable vesting (#343) * Handle bnc vsbond with speical method (#338) * ✨ ($NODE) Add method which handles the speical vsbond(bnc, ..) * 🚑 ($PALLET) Handle vsbond(bnc, ..) with special method in salp * 🚑 ($PALLET) Handle vsbond(bnc, ..) with special method in va * ✅ ($PALLET) Cover new unit-tests onto the above repairs * ✅ ($PALLET) Cover new unit-tests onto the previous fix * 🚑 ($PALLET) Handle vsbond(bnc, ..) as special case in the lm * ✅ ($PALLET) Fix unit-tests for covering th previous hotfix * Xcm refact (#345) * Encode xcm call with relaychain runtime * Fix test * More docs to lm (#346) * 📝 ($PALLET) Refactor docs of lm's error * 📝 ($PALLET) Refactor the docs about all extrinsics * 🎨 ($PALLET) Format the docs * Delete useless code (#342) * 🔥 ($RUNTIME) Delete useless code * 🐛 ($RUNTIME) Fix compiler can't infer type Co-authored-by: Edwin <lark930@gmail.com> * add-lightening-redeem-to-bifrost (#347) * add-lightening-redeem-to-bifrost * Update lib.rs * Update lib.rs Co-authored-by: Edwin <lark930@gmail.com> * Support system api (#350) * V0.9.3 (#353) * disable pallet_xcm * Remove Xcm Transact (#352) * bump native version Co-authored-by: yrong1997 <yrong1997@gmail.com> * Add system api (#351) * Support system api * fix warning * Add README to lm (#349) * 📝 ($PALLET) Add readme for lm(1/3) * 📝 ($PALLET) More .. * 📝 ($PALLET) More .. * 📝 ($PALLET) Compl ch_zn docs of lm * 📝 ($PALLET) Work readme_en for lm * 📝 ($PALLET) Compl readme_en for lm * 🎨 ($PALLET) Try formatting readme_en * 🎨 ($PALLET) Format again * 🎨 * 🎨 * 🎨 * 🎨 * 🎨 * 🐛 ($NODE) Fix interrupt when launch asgard-genesis (#356) * Clear runtime upgrade codes (#348) * Update deps to polkadot-v0.9.11 (#362) * update deps to polkadot-v0.9.11 * fix tests * update orml * bump version to 0.9.6 (#364) * Add salp-lite pallet (#359) * add-vsdot-vsbond (#361) * Revamp xcm for v2 (#366) * Add salp-lite pallet * Revamp xcm for v2 * Fix dev executor (#367) * Revamp fund migration (#368) * Add release script for ci[skip ci] (#369) * Revamp message id (#371) * Revamp message id * 🐛 ($RUNTIME) Reorder multisig accounts Co-authored-by: Allen Pocket <AllenPocketGamer@Gmail.com> * Fix VersionWrapper (#372) * minor fix (#374) * fix support of token dot (#384) * Update for xcm v2 (#385) * feat: 🎸 add pallet_identity (#375) * feat: 🎸 add pallet_identity * feat: 🎸 sort the pallet order of runtime * feat: 🎸 add pallet_proxy for bifrost runtime * Add call switchgear & combine benchmark fixes from Allen and Ron (#386) * Add benchmark for salp-lite * 🐛 ($PALLET) Fix bancor bench error * 🐛 ($PALLET) Fix vtoken-mint bench error * 🔧 ($PROJ) Add more phony * 🐛 ($PALLETS) Fix benchmark errors that occur by compile * ✨ ($RUNTIME) Supple the benchmark settings that missing on Bifrost * 🔥 ($RUNTIME) Unlist pallet_* benchmarks * ♻️ ($SCRIPT) Refactor script that generates weightInfos * 🔥 ($RUNTIME) Remove useless code * ♻️ ($SCRIPT) Refactor .. * 👷 ($CI) Try to generate all-runtime weight files * 🎨 ($RUNTIME) Format .. * 🚧 ($CI) Close check & test temporarily * 🚧 ($CI) Working around.. * 🐛 ($SCRIPT) Fix Syntax error 2 * 👷 ($CI) Modify ci flow * 🐛 ($CI) Fix ci syntax error * 🐛 ($PALLET) Fix bench errors of lightening-redeem * 🐛 ($CI) Remove file_pattern option * 🤖 ($WEIGHT) Generate weightInfo files automatically * fix support of token dot (#384) * add-call-switchgear pallet * add diabling token transfer functionality Co-authored-by: yrong1997 <yrong1997@gmail.com> Co-authored-by: Allen Pocket <AllenPocketGamer@Gmail.com> Co-authored-by: AllenPocketGamer <AllenPocketGamer@users.noreply.github.com> * Generate WeightInfo Automatically (#380) * 🐛 ($PALLET) Fix bancor bench error * 🐛 ($PALLET) Fix vtoken-mint bench error * 🔧 ($PROJ) Add more phony * 🐛 ($PALLETS) Fix benchmark errors that occur by compile * ✨ ($RUNTIME) Supple the benchmark settings that missing on Bifrost * 🔥 ($RUNTIME) Unlist pallet_* benchmarks * ♻️ ($SCRIPT) Refactor script that generates weightInfos * 🔥 ($RUNTIME) Remove useless code * ♻️ ($SCRIPT) Refactor .. * 👷 ($CI) Try to generate all-runtime weight files * 🎨 ($RUNTIME) Format .. * 🚧 ($CI) Close check & test temporarily * 🚧 ($CI) Working around.. * 🐛 ($SCRIPT) Fix Syntax error 2 * 👷 ($CI) Modify ci flow * 🐛 ($CI) Fix ci syntax error * 🐛 ($PALLET) Fix bench errors of lightening-redeem * 🐛 ($CI) Remove file_pattern option * 🤖 ($WEIGHT) Generate weightInfo files automatically Co-authored-by: AllenPocketGamer <AllenPocketGamer@users.noreply.github.com> Co-authored-by: Edwin <lark930@gmail.com> * Fix try runtime migration (#389) * 🔥 ($CI) Annote bench (#390) * Sync dev chain (#391) * Add xcm transact tests&Fix break tests * Sync dev chain with bifrost * fix-callswitchgear-in-dev (#392) * Update deps to polkadot-v0.9.12 (#394) * Update deps to polkadot-v0.9.12 * update codec to 2.3.0 * 🐛 ($PALLET) Fix the encode-method is called by lm::rpc (#395) * Rich benchmarkings (#396) * orml-currencies benchmarks added * orml-tokens benchmarks added * ban ZLK transfer and PhragmenElection in bifrost rutnime (#398) * Refact client & dev chain (#393) * Add xcm transact tests&Fix break tests * Refact dev chain - reuse asgard for dev and clean unused codes - integrate rpc api and cutomized for different runtime * Revamp client Co-authored-by: herryho <herry.heyi@gmail.com> * change dot ed value and the order of zlk banned call (#399) * change-flexible-fee-format (#401) * 🐛 ($PALLET) Fix a potential bug about ChargedPoolIds (#403) * Bifrost v0.9.8 (#388) * Bump version to v0.9.8 * Salp revamp (#397) * Add multisig account for salp lite * Revamp salp flow for unlock&refund * update ConfirmSalpLiteConfirmAsMultiSig * fix * fix * use default weight temporary * Fix for salp-lite-v0.9.8 (#400) * Fix for salp-lite-v0.9.8 * fix rpc * change dot ed value and the order of zlk banned call (#399) * change-flexible-fee-format (#401) * V0.9.8 fix (#402) * Fix salp-lite - revamp runtime configurations - remove unlock/batch_unlock & fix tests&weights - convert balance for rpc * Refact:move salp-lite rpc to salp * fix (#405) Co-authored-by: yrong1997 <yrong1997@gmail.com> Co-authored-by: Herry Ho <45537372+herryho@users.noreply.github.com> * remove zenlink transfer control (#418) * Upgrade components and introduce srtool into ci flow (#419) * Bump version to `v0.9.10` (#416) * Add `liquidity-mining-dot`: 🐛 ($PALLET) Fix compile error ✨ ($RUNTIME) Add lm-dot to asgard-runtime 🐛 ($PALLET) Fix unit-test error occurs by upgrading to 0.9.11 🐛 ($PALLET) Fix compiler error occurs by upgrading to 0.9.11 🐛 ($RUNTIME) Fix asgard-runtime error occurs by lm's runtime-api ✨ ($RUNTIME) Refactor lm rpc & runtime_api; Add lmd to Dust ✨ ($RUNTIME) Add lm_dot to bifrost ✨ ($PALLET) Add instance ability to lm * minor fix * remove unused code * Fix to allow contribute when unlocked (#407) * Fix to allow contribute when unlocked * Remove deprecated migration * 🐛 ($RUNTIME) Reorder pallet instance * minor fix * ⬆️ ($RUNTIME) Bump version to v0.9.10 * bump native version to 0.9.10 Co-authored-by: Edwin Wang <lark930@gmail.com> Co-authored-by: yrong1997 <yrong1997@gmail.com> * Bifrost v0.9.10 (#424) * Add `liquidity-mining-dot`: 🐛 ($PALLET) Fix compile error ✨ ($RUNTIME) Add lm-dot to asgard-runtime 🐛 ($PALLET) Fix unit-test error occurs by upgrading to 0.9.11 🐛 ($PALLET) Fix compiler error occurs by upgrading to 0.9.11 🐛 ($RUNTIME) Fix asgard-runtime error occurs by lm's runtime-api ✨ ($RUNTIME) Refactor lm rpc & runtime_api; Add lmd to Dust ✨ ($RUNTIME) Add lm_dot to bifrost ✨ ($PALLET) Add instance ability to lm * minor fix * remove unused code * Fix to allow contribute when unlocked (#407) * Fix to allow contribute when unlocked * Remove deprecated migration * 🐛 ($RUNTIME) Reorder pallet instance * minor fix * ⬆️ ($RUNTIME) Bump version to v0.9.10 * bump native version to 0.9.10 * zenlink klast data migration (#423) Co-authored-by: Allen Pocket <AllenPocketGamer@Gmail.com> Co-authored-by: yrong1997 <yrong1997@gmail.com> Co-authored-by: Herry Ho <45537372+herryho@users.noreply.github.com> * Fix ci & Upgrade toolchain (#422) * Currency unit (#413) * Fix to allow contribute when unlocked * Refact currency unit with decimals * Fix ed per review * Increase fee & Fix merged error Co-authored-by: Edwin <lark930@gmail.com> * Fix benchmark & Add to ci (#428) * remove zenlink data migration code (#429) * hot fix for currency (#431) * Bifrost v0.9.12 (#425) * Add `liquidity-mining-dot`: 🐛 ($PALLET) Fix compile error ✨ ($RUNTIME) Add lm-dot to asgard-runtime 🐛 ($PALLET) Fix unit-test error occurs by upgrading to 0.9.11 🐛 ($PALLET) Fix compiler error occurs by upgrading to 0.9.11 🐛 ($RUNTIME) Fix asgard-runtime error occurs by lm's runtime-api ✨ ($RUNTIME) Refactor lm rpc & runtime_api; Add lmd to Dust ✨ ($RUNTIME) Add lm_dot to bifrost ✨ ($PALLET) Add instance ability to lm * ⬆️ ($RUNTIME) Upgrade to 909 * minor fix * remove unused code * Fix to allow contribute when unlocked (#407) * Fix to allow contribute when unlocked * Remove deprecated migration * 🐛 ($RUNTIME) Reorder pallet instance * minor fix * ⬆️ ($RUNTIME) Bump version to v0.9.10 * ✨ ($PALLET) Add instance to va * ⬆️ ($RUNTIME) Bump version to v0.9.12 * ✨ ($RUNTIME) Add vsbond-auction to bifrost * ✨ ($PALLET) vsbond-auction supports vsbond(bnc/ksm/dot) now * ✨ ($PALLET) Add real weight to vsbond-auction * 🐛 ($PALLET) Fix benchmark * 🐛 ($PALLET) Fix a bug * ✅ ($PALLET) Fix test * 🔥 ($PALLET) Remove custom paraId * 🎨 ($PALLET) Delete duplicate code * 🎨 ($PALLET) Format code * cargo +nightly fmt * add rust-toolchain.toml * ✨ ($PALLET) Add instance to va * ✨ ($RUNTIME) Add vsbond-auction to bifrost * ✨ ($PALLET) vsbond-auction supports vsbond(bnc/ksm/dot) now * 🐛 ($PALLET) Fix after upgrade * ✅ ($PALLET) Fix test * 🎨 ($PALLET) Improve code * ⬆️ ($RUNTIME) Bump version to `v0.9.12` * 🐛 ($PALLET) Discard the deposit be lower than ed when user redeems * ✨ ($PALLET) Add singleTokenPool to liquidityMining * ✅ ($PALLET) Compl liquidityMining unit-tests * fix Dockerfile * ✨ ($PALLET) Add instance to va * ✨ ($RUNTIME) Add vsbond-auction to bifrost * ✨ ($PALLET) vsbond-auction supports vsbond(bnc/ksm/dot) now * 🐛 ($PALLET) Fix after upgrade * ✅ ($PALLET) Fix test * 🎨 ($PALLET) Improve code * ⬆️ ($RUNTIME) Bump version to `v0.9.12` * 🐛 ($PALLET) Discard the deposit be lower than ed when user redeems * ✨ ($PALLET) Add singleTokenPool to liquidityMining * ✅ ($PALLET) Compl liquidityMining unit-tests * fix Dockerfile * 🔧 ($RUNTIME) Change vsbond-auction constant config * Fix to 16x tranfer fee comparing with 0.9.10 (#434) Co-authored-by: Allen Pocket <AllenPocketGamer@Gmail.com> Co-authored-by: yrong1997 <yrong1997@gmail.com> * Fix integration tests & Optimize binary (#432) > fix and add integration tests back > add sibling crosschain tests > optimize for lto binary * Bifrost polkadot runtime (#430) * half-way * half-way * add sudo module to the bifrost-polkadot runtime * add DealWithFees struct to depoist fees and tips to Bifrost treasury * add asgard-polkadot-runtime * Fix differ rpc from runtime * Revert "add asgard-polkadot-runtime" This reverts commit 872bdec. * format * Refact with seperated full/light client * Remove bifrost-polkadot in with-all-runtime * adjustments on the bootnodes and root account * change light rpc to the name of full_polkadot * small adjustments * set WeightInfo of all pallets to () * more refactor * cargo +nightly fmt * fix the conversion issue of DOT precision * more refactor * fix different features integration issues with runtimes * update bifrost-polkadot.json * back to the package name with bifrost-kusama-runtime version * fix bifrost-polkadot-runtime spec version * resolve conflicts * fix agard native token ed Co-authored-by: yrong <yrong1997@gmail.com> Co-authored-by: Edwin Wang <lark930@gmail.com> * 🚑 ($PALLET) Quick fix for vsbond-auction (#435) * 🚑 ($RUNTIME) Imprv max deposit in liquidity pool (#438) * Add token pha & more (#427) * fix SS58prefix * add decimals presentation for different tokens * add support for pha * encapsulate properties object * resolve conflicts for bifrost-polkadot runtime * remove duplicate token properties in chainspec Co-authored-by: yrong <yrong1997@gmail.com> * Update deps to polkadot-v0.9.13 and move rust edition to 2021 (#439) * Update deps to polkadot-v0.9.13 and move rust edition to 2021 * Remove node/inspect from workspace * Revamp redeem flow in salp-lite (#440) * fix wasm build script (#445) * feat: 🎸 add build-bifrost-wasm-jenkins for Makefile (#446) * feat: 🎸 add build-bifrost-wasm-jenkins for Makefile * fix: 🐛 fix build-wasm.sh * Update zenlink to rely on Polkadot-0.9.13 dependencies (#452) * add merkle distributor pallet and zenlink bootstrap reward functionality (#443) * add merkle distributor pallet and zenlink bootstrap reward functionality * change merkle distributor palletId * update zenlink dependency * add transactional macro to callables (#451) * [skip ci] fix benchmark name (#454) * Revamp salp(lite) with configurable multisig account (#444) * Revamp salp(lite) with configurable multisig account * Add salp multisig account to spec&runtime migration * Fix breaking test&some refact * Revamp salp-lite to support failed-fund-continue * more tests * more tests * remove CustomOnRuntimeUpgrade Co-authored-by: Edwin Wang <lark930@gmail.com> * add a overall control toggle (#449) * add a overall control toggle * pallet_name_string to lowercase Co-authored-by: Edwin Wang <lark930@gmail.com> * Add edit fund interface & Some fix (#457) * Add edit fund interface & Some fix * Remove unused codes * [skip ci] add named-profiles features (#459) * add-modify-vestingInfo-function to the vesting pallet (#450) * add-modify-vestingInfo-function to the vesting pallet * rewrite set_per_block * fix test * fix time check * fix time check and add unit testing * Revamp vsbond auction (#448) * revamp logic finished * tests fixed * on-runtime-upgrade code * try-runtime code * add force_revoke * fix existential deposit transfer problem * delete commented code * remove existential deposit type from config trait * Bifrost v0.9.16 (#458) * fix para id * cargo +nightly fmt * fix * [skip ci] remove parachain-id (#464) * move bifrost runtime to bifrost-kusama (#463) * remove VsbondAuctionOnRuntimeUpgrade (#465) * Bifrost V0.9.18 (#471) * add force_set_cliff to pallet Vesting * bump version to v0.9.18 * Add lock-time to redeem-operation of liquidity-pool (#462) * ✨ ($PALLET) Add new properties to lm * ♻️ ($PALLET) Adapt with PoolInfo's modification * 🐛 ($PALLET) Fix unit-tests * ♻️ ($PALLET) Refactor redeem * ✨ ($PALLET) Compl unlock function * ✨ ($PALLET) Fix redeem_inner & Compl unlock * ✨ ($PALLET) Compl cancel_unlock * ✅ ($PALLET) Compl unit-tests of unlock * ✅ ($PALLET) More unit-tests * ✅ ($PALLET) More unit-tests * 🔧 ($PALLET) Fix bench & Add new weights * 🐛 ($RUNTIME) Fix weights by hand * ✅ ($PALLET) Compl lm storage migration * 🐛 ($PALLET) Fix compile error * 🗃️ ($RUNTIME) Modify OnRuntimeUpgrade * 🐛 ($PALLET) Fix migraiton error * 🐛 ($PALLET) Fix potential overflow risk * [skip ci] fix build-wasm.sh * Revert "Add lock-time to redeem-operation of liquidity-pool (#462)" (#472) This reverts commit f7b5112. Co-authored-by: Allen Pocket <AllenPocketWork@Gmail.com> * [skip ci] update srtool to 1.57.0 (#474) * Support statemine asset transfer (#420) * Support statemine asset transfer * Add statemine testcases & Fix integration * Rmrk integration * Revamp asgard for westend integration * Regenerate asgard session keys&help script in makefile * Fix merge error * Remove unclear USDT impl & Prepare for upcoming change polkadot#4470 cumulus#831 * Bifrost v0.9.20 (#475) * bump version to v0.9.20 * add RMRK to chain spec * Bifrost v0.9.22 (#476) * 🔀 ($FEATURE) Add time limit to lm's redeem * ⬆️ ($RUNTIME) Upgrade to v0.9.22 * update merkle-distributor (#479) * Revamp salp with fund continue flow (#480) * Revamp salp with fund continue flow - add continue failed fund - revamp refund & redeem accordingly - some other refactor remove deprecated codes * Fix breaking benchmarks * add bifrost stage chain spec (#467) * V0.9.23 (#482) * Release v0.9.23 * Fix benchmark in ci * Bifrost v0.9.24 (#485) * add zlk as cross-chain fee * fmt * update runtime and native version to v0.9.24 * update lock file * fmt Cargo.lock Co-authored-by: Edwin Wang <lark930@gmail.com> * Happy new year 2022 (#486) * [skip ci] Optimize release (#487) * [skip ci] Remove cargo-features = ["named-profiles"] (#488) * [skip ci] Remove `resolver = "2"` since it's default settings in edition 2021 (#489) * [skip ci] Update bootnodes for bifrost-kusama runtime (#493) * Bifrost v0.9.25 (#492) * Bump to v0.9.15 * Bump and integrate merkle-distributor * Fix integration test * Fix check failed * Fix salp unlock issue * Fix for CanonicalLocation compatibility * Bump to v0.9.25 * Remove merkle-distributor from repo * Fix per review * Bump depencencies * Fix salp xcm weight&Bump zenlink Co-authored-by: yrong <yrong1997@gmail.com> Co-authored-by: ubuntu <ubuntu@localhost.localdomain> Co-authored-by: Edwin Wang <lark930@gmail.com> * [skip ci] Fix bootnodes (#495) * Bifrost v0.9.26 (#494) * staking integration without nimbus * Update weight for asgard * Revamp spec&runtime param for staking * Document usage and apis * Inflation as configurable * Fix for test * Release v0.9.23 * Sync with develop * Fix benchmark in ci * Add to bifrost runtime * Improve doc&Tweak staking params * Fix staging spec&some staking params * Release v0.9.30 * Bump to v0.9.30 * Remove unused * For staking migration * Params for quick test only * Try runtime test for staking migration * Revamp reward account * Upgrade to v0.9.16 * Add SignedExtra check&Fix dev chain * Fix salp unlock issue * Fix per review * Remove staking for 0.9.26 * Bump to 0.9.26 * Bifrost v0.9.25 (#492) * Bump to v0.9.15 * Bump and integrate merkle-distributor * Fix integration test * Fix check failed * Fix salp unlock issue * Fix for CanonicalLocation compatibility * Bump to v0.9.25 * Remove merkle-distributor from repo * Fix per review * Bump depencencies * Fix salp xcm weight&Bump zenlink Co-authored-by: yrong <yrong1997@gmail.com> Co-authored-by: ubuntu <ubuntu@localhost.localdomain> Co-authored-by: Edwin Wang <lark930@gmail.com> * [skip ci] Fix bootnodes (#495) * Fix salp xcm weight&Bump zenlink&Fix statemine xcm * Allow issue when fund success * Fix break test * [skip ci] Some fixes * Fix build wasm * fix try-runtime * Fix benchmark * For fast test and rococo as relaychain * Allow statemine asset back to arbitary account * For sibling chain test Co-authored-by: ubuntu <ubuntu@localhost.localdomain> Co-authored-by: Kadokura <ymlll0508@gmail.com> Co-authored-by: Edwin Wang <lark930@gmail.com> * add dependabot.yml (#468) * Bump serde_json from 1.0.78 to 1.0.79 (#496) Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.78 to 1.0.79. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.78...v1.0.79) --- updated-dependencies: - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Refact xcm interface and fee charge (#503) * Refact xcm interface and fee charge * Bump version * Remove migration * Clean packages * Add ForeignAsset type into CurrencyId * Add pallet asset-registry * test case for CurrencyId::ForeignAsset * fix asset-registry * support foreign asset conversion * Support Moonriver Native token Co-authored-by: Allen Pocket <AllenPocketWork@Gmail.com> Co-authored-by: yrong1997 <yrong1997@gmail.com> Co-authored-by: Herry Ho <45537372+herryho@users.noreply.github.com> Co-authored-by: Allen Pocket <AllenPocketGamer@Gmail.com> Co-authored-by: yooml <ymlll0508@gmail.com> Co-authored-by: wodlj1314 <72777624+wodlj1314@users.noreply.github.com> Co-authored-by: AllenPocketGamer <AllenPocketGamer@users.noreply.github.com> Co-authored-by: herryho <herry.heyi@gmail.com> Co-authored-by: ubuntu <ubuntu@localhost.localdomain> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.