-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce abstraction for CurrencyId into farming pallet #960
Introduce abstraction for CurrencyId into farming pallet #960
Conversation
Run command |
Hi @ark930, we have fixed the failing command and merged with the latest dev branch. Running tests locally seems to work okay, could you please give it a try at the CI? |
Sorry it failed with check. Must have broken with the merge. |
@gianfra-t |
Thanks @ark930, I have replaced the currency id in the benchmarks for the default so it is compatible with the generic implementation. I believe this should not introduce any fundamental difference, but please let me know. |
Farming Pallet is very useful and this PR focused to Introduce abstraction for currency id into farming pallet via
loose pallet coupling
that is more flexible and preferable in most cases.Here is the changes that was added:
CurrencyId
for farming palletPolkadot
/Kusama
)Once this changes was merged anyone will able to use farming pallet in their runtimes.