-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit config to provide feedback on code quality before pushing #17
Conversation
Add Ruff, pre-commit plugins to the VSCode devcontainer. Add Ruff, pre-commit to dev dependencies. Specify pre-commit to install on post-install step. Update from python 3.10 to python 3.12. Ensure the poetry.lock file is now consistent with pyproject.toml. |
@nqngo can you clarify "Specify pre-commit to install on post-install step"? Do you mean that I should write a hook on "post-install" event for pre-commit install? |
@nqngo I realized that the changes I made had already been done last night |
My bad. The comment was around what has been done on my commit and not a task list. Just to clarify what I've setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a few scripts in the poetry config file to run ruff, so we can also run it manually.
Do you have any example of the custom script? I don't know why do we need to have some custom script for running ruff. |
Ignore my previous comment 😓 I had a look at poetry from the |
In pre-commit config, I use the following hook