Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Introduce MyPy to enforce strict typing #30

Merged
merged 3 commits into from
Feb 25, 2024
Merged

Feat: Introduce MyPy to enforce strict typing #30

merged 3 commits into from
Feb 25, 2024

Conversation

samhwang
Copy link
Contributor

  • feat: install mypy
  • chore: add missing type definitions
  • feat: add typecheck job in CI action

@samhwang samhwang requested a review from nqngo February 25, 2024 08:35
samhwang
samhwang commented Feb 25, 2024
View reviewed changes
pyproject.toml
@@ -72,6 +73,16 @@ indent-style = "space"
skip-magic-trailing-comma = false
line-ending = "lf"

[tool.mypy]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These rules were taken from: https://careers.wolt.com/en/blog/tech/professional-grade-mypy-configuration

We can fine tune this as we go.

@samhwang samhwang merged commit 17e6673 into main Feb 25, 2024
4 checks passed
@samhwang samhwang deleted the feat/add-mypy branch February 25, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nqngo nqngo nqngo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samhwang @nqngo