Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update README.md #7

Merged
merged 1 commit into from
Feb 8, 2024
Merged

update README.md #7

merged 1 commit into from
Feb 8, 2024

Conversation

hungdtrn
Copy link
Contributor

@hungdtrn hungdtrn commented Feb 8, 2024

No description provided.

nqngo
nqngo approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@nqngo nqngo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however, could you please ensure the merge commit message is more sensible. Change it to something like:
Add dependencies instruction to README

@nqngo
Copy link
Collaborator

nqngo commented Feb 8, 2024

Make sure you squash and update the commit message.

@hungdtrn
Copy link
Contributor Author

hungdtrn commented Feb 8, 2024

Thank you!, I will pay attention to my commit message next time.

@hungdtrn hungdtrn closed this Feb 8, 2024
@hungdtrn hungdtrn reopened this Feb 8, 2024
@hungdtrn hungdtrn merged commit dfa8d56 into main Feb 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nqngo nqngo nqngo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hungdtrn @nqngo