Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Webpack to compile emoji-mart using babel-loader #255

Merged
merged 5 commits into from
Jun 8, 2022

Conversation

AbhayVAshokan
Copy link
Member

@AbhayVAshokan AbhayVAshokan commented Jun 8, 2022

Fixes #252

  • Fixed issue with latest emoji-mart version not working with webpack-dev-server of neeto projects (Refer explanation below).
  • Downgraded react-router-dom to v5.3.1. Frontend standardization recommends this version, and the newer version raises warnings while installing editor.

@render
Copy link

render bot commented Jun 8, 2022

@AbhayVAshokan AbhayVAshokan changed the title Downgraded emoji-mart package Updated Webpack to compile emoji-mart using babel-loader Jun 8, 2022
@AbhayVAshokan
Copy link
Member Author

I have managed to solve the emoji-mart issue without downgrading the package. I have updated the Webpack configuration to compile the emoji-mart package from the node_modules folder again by the babel-loader of neetoEditor.

Here is a demo and explanation about the same: https://vimeo.com/718186685/4f4111abc5

@labeebklatif _a please review.
cc: @karthiknmenon

Copy link
Contributor

@labeebklatif labeebklatif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@labeebklatif
Copy link
Contributor

labeebklatif commented Jun 8, 2022

Similar issue in the emoji-mart package missive/emoji-mart#613

@labeebklatif labeebklatif merged commit 61147c8 into master Jun 8, 2022
@labeebklatif labeebklatif deleted the 252-issue-while-runnning-webpack-dev-server branch June 8, 2022 10:22
@gabibianconi
Copy link

Is there a tentative date for a release with this fix? @labeebklatif

@labeebklatif
Copy link
Contributor

@gabibianconi The fix is already released (v.0.3.47) on 8th Jun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues while running webpack dev server
3 participants