Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quantms subworkflows to be built #8

Closed
daichengxin opened this issue Nov 8, 2021 · 10 comments
Closed

quantms subworkflows to be built #8

daichengxin opened this issue Nov 8, 2021 · 10 comments
Labels
enhancement New feature or request

Comments

@daichengxin
Copy link
Collaborator

What subworkflow to be built? such as QC?

DecoyDatabase and OpenmsPeakpicker should be called as single module.

@daichengxin daichengxin added the enhancement New feature or request label Nov 8, 2021
@ypriverol
Copy link
Member

ypriverol commented Nov 8, 2021

@daichengxin @jpfeuffer :

  • DecoyDatabase should be one single module because is just one step.
  • OpenmsPeakpicker I think could be added to the Conversion subworkflow (the one that you already implemented). The OpenmsPeakpicker is part of the conversion process and should be enable on request by a parameter.

@ypriverol
Copy link
Member

ypriverol commented Nov 8, 2021

The next subworkflows:

  • DatabaseSearchEngines including the following processes: process search_engine_msgf, process search_engine_comet
  • index_peptides: Could be a single module that can be reuse multiple times.
  • PercolatorPeptideIdBoost including the following processes: extract_percolator_features, percolator
  • PSMFDRControl including the following processes: fdr_idpep, idpep, idscoreswitcher_to_qval, consensusid , fdr_consensusid, idfilter
  • PhosphoScoring including the following processes: idscoreswitcher_for_luciphor, luciphor
  • ProteinInference including idemapper, file_merge , protein_epifany, protein_inference, epi_filter , resolve_conflict
  • ProteinQuant including pro_quant, MsstatsConverter
  • pmultiqc should be a single module.

What do you think about this proposal @daichengxin @jpfeuffer ?

@ypriverol
Copy link
Member

I think index_peptides can be the end of the DatabaseSearchEngines subworkflow because all the time will be needed.

@daichengxin
Copy link
Collaborator Author

DatabaseSearchEngines is ok. And they shared parameters. PercolatorPeptideIdBoost is also ok, they have close relationship. PSMFDRControl seem to have too many modules. idfilter could be a single module that can be reuse in ProteinInference. PhosphoScoring is ok. idemapper and file_merge seem to have no direct relationship with protein inference. idemapper should be with isobaricanalyzer. file_merge can be a single module. ProteinQuant and pmultiqc are ok.

@jpfeuffer
Copy link
Collaborator

jpfeuffer commented Nov 8, 2021

I would do:

  • DatabaseSearchEngines including the following processes: process search_engine_msgf, process search_engine_comet and index_peptides (starting from 2.7.1, indexing is done internally per default anyway)
  • PSMRescoring including the following processes: extract_percolator_features, percolator, fdr_idpep, idpep
  • ConsensusID could also be a single module
  • PSMFDRControl including the following processes: idscoreswitcher_to_qval (if no consensusID was used), fdr_consensusid (if consensusID was used), idfilter
  • PhosphoScoring including the following processes: idscoreswitcher_for_luciphor, luciphor
  • IDMapper could be a single module
  • FileMergecould be a single module
  • ProteinInference including protein_epifany, protein_inference, epi_filter
  • ProteinQuant including resolve_conflict , pro_quant, MsstatsConverter
  • pmultiqc should be a single module.

@ypriverol
Copy link
Member

Looks like a great strategy. I will open independent issues.

@daichengxin
Copy link
Collaborator Author

Isobaricanalyzer could be with IDmapper ? In LFQ, there is no IDMapper

@jpfeuffer
Copy link
Collaborator

Yes could be together, in LFQ this happens in the ProteomicsLFQ step.

@ypriverol
Copy link
Member

ypriverol commented Nov 8, 2021

@daichengxin if everyone agreed with @jpfeuffer #8 (comment) we should do a PR by subworkflow. I have created an issue for each subworkflow. This can help us to review the PRs more easily.

@ypriverol ypriverol added this to the first release v1.0 milestone Nov 14, 2021
@ypriverol ypriverol changed the title Subworkflow to be built qunatms subworkflows to be built Nov 14, 2021
@ypriverol ypriverol changed the title qunatms subworkflows to be built quantms subworkflows to be built Nov 14, 2021
@ypriverol
Copy link
Member

Done.

jpfeuffer pushed a commit that referenced this issue Mar 14, 2022
ypriverol pushed a commit that referenced this issue May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants