Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template updated 2.3.1 #139

Merged
merged 25 commits into from
Mar 24, 2022
Merged

Template updated 2.3.1 #139

merged 25 commits into from
Mar 24, 2022

Conversation

ypriverol
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/quantms branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir `).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

nf-core-bot and others added 6 commits March 23, 2022 13:53
…core/quantms into dev

� Conflicts:
�	.github/workflows/awsfulltest.yml
�	.github/workflows/awstest.yml
�	.github/workflows/ci.yml
�	.yamllint.yml
�	CHANGELOG.md
�	CITATIONS.md
�	README.md
�	assets/multiqc_config.yaml
�	docs/output.md
�	docs/usage.md
�	modules.json
�	modules/nf-core/modules/fastqc/main.nf
�	modules/nf-core/modules/fastqc/meta.yml
�	nextflow.config
�	nextflow_schema.json
@github-actions
Copy link

github-actions bot commented Mar 23, 2022

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit aa21791

+| ✅ 145 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.3.2
  • Run at 2022-03-24 13:56:30

@ypriverol ypriverol requested a review from jpfeuffer March 24, 2022 09:12
Copy link
Collaborator

@jpfeuffer jpfeuffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See two comments

assets/multiqc_config.yaml Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
Co-authored-by: Julianus Pfeuffer <pfeuffer@informatik.uni-tuebingen.de>
@bigbio bigbio deleted a comment from daichengxin Mar 24, 2022
.nf-core.yml Outdated Show resolved Hide resolved
.nf-core.yml Outdated
@@ -1,7 +1,7 @@
repository_type: pipeline
lint:
files_unchanged:
- assets/multiqc_config.yaml
- assets/multiqc_config.yml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we remove that?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the linting on nf-core

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it but now CI is failing

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, then let's fix it

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MultiQC linting was rewritten in this release, in the hope that it should not be necessary to ignore for most of the time. I'd be curious as to why you need it here..

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in, what the linting failure is..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were just confused with the meaning of order in MultiQC. I actually thought -123 would mean at the beginning of the report. Should be no linting errors anymore

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok great 👍🏻

I have to check the docs every time for this kind of thing.. https://multiqc.info/docs/#order-of-module-and-module-subsection-output

Next, specify the report_section_order option in your MultiQC config file. Modules and sections in the report are given a number ranging from 10 (section at bottom of report), incrementing by +10 for each section. You can change this number (eg. a very low number to always get at the bottom of the report or very high to always be at the top), or you can move a section to before or after another existing section (has no effect if the other named ID is not in the report).

@jpfeuffer jpfeuffer merged commit 6f2f79b into bigbio:dev Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants