-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template updated 2.3.1 #139
Conversation
…core/quantms into dev � Conflicts: � .github/workflows/awsfulltest.yml � .github/workflows/awstest.yml � .github/workflows/ci.yml � .yamllint.yml � CHANGELOG.md � CITATIONS.md � README.md � assets/multiqc_config.yaml � docs/output.md � docs/usage.md � modules.json � modules/nf-core/modules/fastqc/main.nf � modules/nf-core/modules/fastqc/meta.yml � nextflow.config � nextflow_schema.json
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See two comments
Co-authored-by: Julianus Pfeuffer <pfeuffer@informatik.uni-tuebingen.de>
.nf-core.yml
Outdated
@@ -1,7 +1,7 @@ | |||
repository_type: pipeline | |||
lint: | |||
files_unchanged: | |||
- assets/multiqc_config.yaml | |||
- assets/multiqc_config.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't we remove that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the linting on nf-core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it but now CI is failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, then let's fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MultiQC linting was rewritten in this release, in the hope that it should not be necessary to ignore for most of the time. I'd be curious as to why you need it here..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in, what the linting failure is..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were just confused with the meaning of order in MultiQC. I actually thought -123 would mean at the beginning of the report. Should be no linting errors anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok great 👍🏻
I have to check the docs every time for this kind of thing.. https://multiqc.info/docs/#order-of-module-and-module-subsection-output
Next, specify the
report_section_order
option in your MultiQC config file. Modules and sections in the report are given a number ranging from 10 (section at bottom of report), incrementing by +10 for each section. You can change this number (eg. a very low number to always get at the bottom of the report or very high to always be at the top), or you can move a section to before or after another existing section (has no effect if the other named ID is not in the report).
PR checklist
nf-core lint
).nextflow run . -profile test,docker
--outdir `).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).