Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LFQ part and fixed bugs #20

Merged
merged 8 commits into from
Nov 18, 2021
Merged

Add LFQ part and fixed bugs #20

merged 8 commits into from
Nov 18, 2021

Conversation

daichengxin
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/quantms branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 718fcd5

+| ✅ 136 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • readme - README did not have a Nextflow minimum version mentioned in Quick Start section.

✅ Tests passed:

Run details

  • nf-core/tools version 2.1
  • Run at 2021-11-18 07:16:10

@ypriverol ypriverol self-requested a review November 17, 2021 21:04
@ypriverol ypriverol merged commit 0a2de4f into bigbio:dev Nov 18, 2021
ypriverol pushed a commit that referenced this pull request Mar 20, 2023
@jpfeuffer
Merge pull request #20 from nf-core/dev
19ec5d2 
[Hotfix] Amend to Release 1.0 before tagging/releasing
ypriverol pushed a commit that referenced this pull request May 7, 2024
@daichengxin
Merge pull request #20 from bigbio/dev
ee2c748 
u
mobiusklein pushed a commit to mobiusklein/quantms that referenced this pull request Aug 9, 2024
@ypriverol
Merge pull request bigbio#20 from bigbio/dev
adc1fb2 
Dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypriverol ypriverol ypriverol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daichengxin @ypriverol