Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes in figure, update. #348

Merged
merged 6 commits into from
Jan 25, 2024
Merged

changes in figure, update. #348

merged 6 commits into from
Jan 25, 2024

Conversation

ypriverol
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/quantms branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit bc1745e

+| ✅ 160 tests passed       |+
#| ❔   4 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-24 12:06:01

@ypriverol ypriverol added the documentation Improvements or additions to documentation label Jan 24, 2024
@ypriverol ypriverol linked an issue Jan 24, 2024 that may be closed by this pull request
quantms update figure of SVG pipeline. #347
Closed
daichengxin
daichengxin reviewed Jan 24, 2024
View reviewed changes
docs/images/quantms_metro.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only updated the figures in the readthedoc branch. The Sage look like is not represented by a node as same as other search engines？Maybe it can be unified with the image in readthedocs branch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, you can do a PR first to readthedocs with the better version, and then I will update this PR. Good idea, it was difficult for me to modify the metro image ;)

@ypriverol ypriverol merged commit fd20331 into bigbio:dev Jan 25, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daichengxin daichengxin daichengxin left review comments

@jpfeuffer jpfeuffer Awaiting requested review from jpfeuffer

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

quantms update figure of SVG pipeline.
2 participants
@ypriverol @daichengxin