Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idmapper changes #60

Merged
merged 2 commits into from
Jan 28, 2022
Merged

idmapper changes #60

merged 2 commits into from
Jan 28, 2022

Conversation

ypriverol
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/quantms branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@ypriverol
sdrf -> 0.0.20
0cee76b 
idmapper moved to precursor
@ypriverol
sdrf -> 0.0.20
7848717 
idmapper moved to precursor
@github-actions
Copy link

github-actions bot commented Jan 28, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 7848717

+| ✅ 138 tests passed       |+
#| ❔   2 tests were ignored |#

❔ Tests ignored:

  • files_exist - File is ignored: conf/igenomes.config
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.2
  • Run at 2022-01-28 19:00:59

@ypriverol ypriverol merged commit 208a343 into bigbio:dev Jan 28, 2022
jpfeuffer
jpfeuffer reviewed Jan 28, 2022
View reviewed changes
modules/local/openms/idmapper/main.nf
@@ -38,6 +38,7 @@ process IDMAPPER {
-mz_tolerance $params.mz_tolerance \\
-mz_measure $params.mz_measure \\
-mz_reference $params.mz_reference \\
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot to remove the old param

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the docs/param description for it maybe too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpfeuffer jpfeuffer jpfeuffer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ypriverol @jpfeuffer