You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sorting the default label results in label_list being ['2', 'M', 'T', 'T'] with a length of 4 which then probably leads to leads being true and we have a 6-plex form a 2-plex.
I think the whole label extraction should be more stringent and fail on unknown input with a note that an issue should be opened in this repo to adjust for new labels (and fix bugs). Guessing could lead to issues that are hard to diagnose by users and errors might even go unnoticed.
The text was updated successfully, but these errors were encountered:
sdrf-pipelines/sdrf_pipelines/maxquant/maxquant.py
Line 78 in 96e2a69
Sorting the default label results in
label_list
being['2', 'M', 'T', 'T']
with a length of 4 which then probably leads to leads being true and we have a 6-plex form a 2-plex.I think the whole label extraction should be more stringent and fail on unknown input with a note that an issue should be opened in this repo to adjust for new labels (and fix bugs). Guessing could lead to issues that are hard to diagnose by users and errors might even go unnoticed.
The text was updated successfully, but these errors were encountered: