Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Add actions to settings form template #66

Merged
merged 3 commits into from
Jan 14, 2019

Conversation

jaymcp
Copy link
Member

@jaymcp jaymcp commented Jan 10, 2019

Proposed Changes

  • Add several actions to the Theme Options template to allow the settings to be extended without plugging the entire function.

Will require Wiki updates if merged - please ping me.

@jaymcp jaymcp added the enhancement New feature or request label Jan 10, 2019
Copy link
Member

@ampersarnie ampersarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actions and filters should have a DocBlock as-per-WordPress documentation standards. We also have them elsewhere in the theme so I think we need to stay consistent. Nothing major, just a sentence would do imo.

@jaymcp jaymcp dismissed ampersarnie’s stale review January 14, 2019 16:16

PR updated per changes requested

Copy link
Member

@ampersarnie ampersarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that 👍

@ampersarnie ampersarnie merged commit 73c4de2 into develop Jan 14, 2019
@jaymcp jaymcp deleted the feature/extendible-settings branch January 14, 2019 16:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants