Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter eslint config to not use function #97

Merged
merged 5 commits into from
Aug 24, 2023

Conversation

ampersarnie
Copy link
Member

Description

An issue where ESLint config is not able to load in an editor such as VSCode due to the nature of using a function for compiling the config and linting config not being able to be set. Despite this, linting worked and the issue was not affecting build runs.

Additional config is required for having ESLint running within the editor experience and a package.json needs to be configured using eslintConfig properties:

{
  "name": "my-package",
  "version": "1.0.0",
  "eslintConfig": {
    "extends": "./node_modules/@bigbite/build-tools/configs/eslint",
  },
  "dependencies": {}
}

Change Log

  • Change eslint config to not require function.
  • Updated documentation with config.

@ampersarnie ampersarnie marked this pull request as ready for review August 24, 2023 14:33
@ampersarnie ampersarnie merged commit 5de2339 into bigbite:main Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant