-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Core functionality to obtain and save data #1
Conversation
…x 6.2 issue, mapped components to update theme state on change
I have a feeling prettier might not be configured correctly on this but should be an easy fix, grab me next week and we should be able to sort it pretty quickly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrishall0 great work so far!
I've added a few comments which relate to changes that look like they may need to be applied across the codebase
- sorting dependencies
- avoid accessing
wp
global - use multiline/JSDoc formatted comments
- avoid disabling eslint
- destructure props in components
More details are in the specific comments, but can you go over all files and ensure any fixes are applied across the board?
I'm also getting quite a few eslint errors through the build tools. Mostly related to proptypes and prop destructuring. Can you take a look at these?
To avoid slowing this down I think we could create a separate PR to add prop types but we should aim to get these other things updated on this initial PR if possible.
…p imports, updated eslint comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙌
(http://bigbite.im/v/ju8b5S)
This PR -