Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Core functionality to obtain and save data #1

Merged
merged 34 commits into from
Jun 22, 2023

Conversation

chrishall0
Copy link
Contributor

(http://bigbite.im/v/ju8b5S)

This PR -

  • Uses core functionality to obtain and save data to correct DB value to work with WP FSE
  • Maps data to dynamically render values from object.
  • Renders options in navigator component
  • Maps values to suitable components
  • Renders preview based on selected settings

src/editor/components/fields/ThemerComponent.js Outdated Show resolved Hide resolved
src/editor/components/fields/Field.js Outdated Show resolved Hide resolved
src/editor/components/fields/ThemerComponent.js Outdated Show resolved Hide resolved
@scottblackburn scottblackburn self-requested a review June 2, 2023 15:25
@scottblackburn
Copy link
Collaborator

I have a feeling prettier might not be configured correctly on this but should be an easy fix, grab me next week and we should be able to sort it pretty quickly

inc/class-custom-routes.php Outdated Show resolved Hide resolved
src/editor/components/fields/ComponentMap.js Outdated Show resolved Hide resolved
src/editor/components/fields/Components/FontPicker.js Outdated Show resolved Hide resolved
src/editor/components/fields/Components/FontPicker.js Outdated Show resolved Hide resolved
src/editor/components/fields/Components/SpacingControl.js Outdated Show resolved Hide resolved
src/editor/components/fields/ThemerComponent.js Outdated Show resolved Hide resolved
inc/class-admin.php Outdated Show resolved Hide resolved
inc/class-custom-routes.php Outdated Show resolved Hide resolved
Copy link
Member

@g-elwell g-elwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrishall0 great work so far!

I've added a few comments which relate to changes that look like they may need to be applied across the codebase

  • sorting dependencies
  • avoid accessing wp global
  • use multiline/JSDoc formatted comments
  • avoid disabling eslint
  • destructure props in components

More details are in the specific comments, but can you go over all files and ensure any fixes are applied across the board?

I'm also getting quite a few eslint errors through the build tools. Mostly related to proptypes and prop destructuring. Can you take a look at these?

To avoid slowing this down I think we could create a separate PR to add prop types but we should aim to get these other things updated on this initial PR if possible.

package.json Outdated Show resolved Hide resolved
src/editor/components/ComponentWrapper.js Outdated Show resolved Hide resolved
src/editor/components/fields/Field.js Outdated Show resolved Hide resolved
src/editor/components/fields/Field.js Outdated Show resolved Hide resolved
src/editor/components/fields/Field.js Outdated Show resolved Hide resolved
src/editor/components/fields/Field.js Outdated Show resolved Hide resolved
src/editor/components/fields/Preview.js Outdated Show resolved Hide resolved
inc/class-admin.php Outdated Show resolved Hide resolved
inc/class-loader.php Outdated Show resolved Hide resolved
src/editor/components/fields/Components/FontPicker.js Outdated Show resolved Hide resolved
src/editor/components/fields/Field.js Outdated Show resolved Hide resolved
src/editor/components/fields/ThemerComponent.js Outdated Show resolved Hide resolved
@chrishall0 chrishall0 requested a review from g-elwell June 20, 2023 09:25
inc/class-filters.php Outdated Show resolved Hide resolved
@chrishall0 chrishall0 requested a review from g-elwell June 20, 2023 13:16
src/editor/components/fields/ThemerComponent.js Outdated Show resolved Hide resolved
src/editor/components/fields/ThemerComponent.js Outdated Show resolved Hide resolved
@chrishall0 chrishall0 requested a review from g-elwell June 22, 2023 09:36
Copy link
Member

@g-elwell g-elwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@chrishall0 chrishall0 merged commit 53a933f into main Jun 22, 2023
@g-elwell g-elwell mentioned this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants