Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BBT-119] Hide core admin notices #46

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

g-elwell
Copy link
Member

@g-elwell g-elwell commented Dec 5, 2023

Description

BBT-119 - This PR hides all core WordPress notices from the plugin pages, to prevent them from breaking the layout.

This is achieved using CSS, which should be a reliable approach in this case, however by hiding the notices we are committing to understanding that we won't be able to utilise this type of notice for our own purposes within the plugin.

Change Log

Hides all core notices from plugin pages

Steps to test

  • Install the plugin on a site using an outdated WordPress version
  • Confirm the update notice is shown on other admin pages
  • Confirm the update notice is not shown on pages created by this plugin

Screenshots/Videos

Before:
image

After:
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@g-elwell g-elwell changed the base branch from main to release/1.0.0 December 5, 2023 09:11
@g-elwell g-elwell marked this pull request as ready for review December 5, 2023 09:11
Copy link
Contributor

@Joe-Rouse Joe-Rouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍🏻

@g-elwell g-elwell merged commit b3276aa into release/1.0.0 Dec 5, 2023
1 check passed
@g-elwell g-elwell mentioned this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants