Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: updates config to latest orb and new deployignore targets #5

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

chrishbite
Copy link
Contributor

@chrishbite chrishbite commented Jun 23, 2023

Description

Fixes BBT-19

Updates the Circle CI config.yml to the new standard and the latest BigBite Orb (0.0.64).

The .deployignore file has also been updated to include files and folders not to deploy to the (main|master|preprod|staging|develop|release/[0-9.]+|chore/update-ci) *-built branches.

Tests

  1. Visit https://app.circleci.com/pipelines/github/bigbite/themer?branch=chore%2Fupdate-ci
  2. View the workflows and that the CI is running as expected
    1. First workflow you should see phpcs failing the build, all following workflows had phpcs disabled to test the *-built branches
  3. View https://github.com/bigbite/themer/tree/chore/update-ci-built and confirm files are what is expected in a built branch
  4. Checkout the chore/update-ci-built branch locally, plugin should function as expected

Notes:

  • Circle CI tests were ran on chore/update-ci branch
  • Any future PRs/Branches including this change should now run through the Circle CI pipeline here
  • Any branches matching main|master|preprod|staging|develop|release/[0-9.]+|chore/update-ci should also create a *-built branch

Change Log

  • Updated to latest BigBite Circle CI Orb (0.0.64)
  • New Circle CI config.yml file standard
  • File and folder additions to .deployignore file

@chrishbite chrishbite added the enhancement New feature or request label Jun 23, 2023
@chrishbite chrishbite marked this pull request as draft June 23, 2023 14:29
@chrishbite chrishbite marked this pull request as ready for review June 23, 2023 14:31
Copy link
Member

@g-elwell g-elwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @chrishbite and works as expected!

I've noticed that our build tools lints within the build script, but wp-scripts doesn't, so wondering whether we should update the npm script to "build:prod": "wp-scripts lint-js ./src && wp-scripts build" as part of this PR to ensure that JS linting is included in CI

@chrishbite
Copy link
Contributor Author

chrishbite commented Jun 23, 2023

I've noticed that our build tools lints within the build script, but wp-scripts doesn't, so wondering whether we should update the npm script to "build:prod": "wp-scripts lint-js ./src && wp-scripts build" as part of this PR to ensure that JS linting is included in CI

Good spot @g-elwell, I've implemented that now 👍

"build:prod": "wp-scripts lint-js ./src && wp-scripts build"

@chrishbite chrishbite requested a review from g-elwell June 23, 2023 15:43
@chrishbite chrishbite merged commit 1202719 into main Jun 26, 2023
@g-elwell g-elwell mentioned this pull request Jul 26, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants