-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bbt-52/53]UI styles and sticky preview #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @squarewave17 !
This works well, I've added a tiny inline comment about CSS linting 😅
I had some thoughts whether we should contain the block content inside the preview, but I think this would be a separate issue as it would need to account for full vs content vs wide width blocks and how we represent them within the preview. So, I'm happy to move ahead with this once the linting is sorted and address those issues later on.
Yeah I see what you mean. Maybe just a little padding on the preview window would be an interim solution? |
Yeah that would be an improvement, I'm happy to leave it for now though and will pop an issue in for us to address separately so we can go ahead and merge this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Work's great, thanks @squarewave17 !
Description
This PR addresses 52 and 53 - combined together as they are both uI related
Change Log
###Note: Adding sticky to the preview poses a new issue which can be found here
Steps to test
Screenshots/Videos
Video
Checklist: