Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bbt-52/53]UI styles and sticky preview #56

Merged
merged 3 commits into from
May 9, 2024

Conversation

squarewave17
Copy link
Contributor

@squarewave17 squarewave17 commented May 8, 2024

Description

This PR addresses 52 and 53 - combined together as they are both uI related

Change Log

  • Added a background color of #F6F7F7 to background
  • Changed how width is set at desktop so that 20px margin can be maintained between
  • Made the themer preview sticky so it remains is view while editing parameters

###Note: Adding sticky to the preview poses a new issue which can be found here

Steps to test

  • View the UI and ensure that the background color is correct
  • ensure sticky behaviour behaves as expected
  • View the UI on both your mac and wide monitor to ensure the 20px gap is there in deskop and scales correctly. The responsive viewports should resize as normal

Screenshots/Videos

Video

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@squarewave17 squarewave17 changed the base branch from main to release/1.0.0 May 8, 2024 14:33
@squarewave17 squarewave17 marked this pull request as ready for review May 8, 2024 14:51
@squarewave17 squarewave17 added the enhancement New feature or request label May 8, 2024
Copy link
Member

@g-elwell g-elwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @squarewave17 !

This works well, I've added a tiny inline comment about CSS linting 😅

I had some thoughts whether we should contain the block content inside the preview, but I think this would be a separate issue as it would need to account for full vs content vs wide width blocks and how we represent them within the preview. So, I'm happy to move ahead with this once the linting is sorted and address those issues later on.

src/editor/styles/navigator.scss Outdated Show resolved Hide resolved
@squarewave17 squarewave17 requested a review from g-elwell May 9, 2024 12:28
@squarewave17
Copy link
Contributor Author

Thanks for the contribution @squarewave17 !

This works well, I've added a tiny inline comment about CSS linting 😅

I had some thoughts whether we should contain the block content inside the preview, but I think this would be a separate issue as it would need to account for full vs content vs wide width blocks and how we represent them within the preview. So, I'm happy to move ahead with this once the linting is sorted and address those issues later on.

Yeah I see what you mean. Maybe just a little padding on the preview window would be an interim solution?

@g-elwell
Copy link
Member

g-elwell commented May 9, 2024

Thanks for the contribution @squarewave17 !
This works well, I've added a tiny inline comment about CSS linting 😅
I had some thoughts whether we should contain the block content inside the preview, but I think this would be a separate issue as it would need to account for full vs content vs wide width blocks and how we represent them within the preview. So, I'm happy to move ahead with this once the linting is sorted and address those issues later on.

Yeah I see what you mean. Maybe just a little padding on the preview window would be an interim solution?

Yeah that would be an improvement, I'm happy to leave it for now though and will pop an issue in for us to address separately so we can go ahead and merge this PR

Copy link
Member

@g-elwell g-elwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work's great, thanks @squarewave17 !

@g-elwell g-elwell merged commit a2f277b into release/1.0.0 May 9, 2024
1 check passed
@g-elwell g-elwell mentioned this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants