Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BBT-62] Change visual preview to code view (fixes) #70

Merged
merged 1 commit into from
Jun 27, 2024
Merged

[BBT-62] Change visual preview to code view (fixes) #70

merged 1 commit into from
Jun 27, 2024

Conversation

chrishall0
Copy link
Contributor

@chrishall0 chrishall0 commented Jun 27, 2024 •
edited
Loading

Description

Fixes #62 - Addresses feedback given here #62 (comment)

Change Log

  • Render whole themeConfig object rather than just styles and settings
  • Wraps code view in <pre> and <code> tags
  • Fixes CSS issue where code view section was too long

Screenshots/Videos

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@chrishall0 chrishall0 requested a review from g-elwell June 27, 2024 07:41
@chrishall0 chrishall0 self-assigned this Jun 27, 2024
@chrishall0 chrishall0 mentioned this pull request Jun 27, 2024
Closed
g-elwell
g-elwell approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@g-elwell g-elwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks for jumping on these so quickly!

@g-elwell g-elwell merged commit f8ee07f into release/1.0.0 Jun 27, 2024
1 check passed
@squarewave17 squarewave17 mentioned this pull request Jun 27, 2024
Merged
@g-elwell g-elwell mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-elwell g-elwell g-elwell approved these changes

Assignees

@chrishall0 chrishall0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrishall0 @g-elwell