BBT-46 Implement basic plugin UI #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! I think we may want to remove the core notices/padding so that our main element covers the entire view. Looks like Content Query may have solved the required style overrides to achieve this so perhaps @chrishbite can give some guidance on that? |
|
Cheers @g-elwell, looked into CQ and implemented that change now if you want to have another look |
|
Awesome, looks much better! Minor tweak, can we adjust the top nav border to only Before:
After:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://b5ecom.atlassian.net/browse/BBT-46
Updates to Themer UI to match figma doc (https://www.figma.com/file/fWpNJ5grZmisFBnCUPqrrv/Themer?type=design&node-id=60-377&mode=design&t=Gj1ibH7LSzivkBQZ-0)
Use of placeholders for tab panels in place as structure to be done in the future.
Preview component also in a separate ticket so current preview styling done as a base
Screenshots/Videos