Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a property in wpContents which activates plugins after the theme is activated. #106

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

PaulREnglish
Copy link
Contributor

@PaulREnglish PaulREnglish commented Jul 21, 2022

Description

Fixes #95 - Adds support for a new property called pluginsActivatedAfterTheme in the wpContents object in cypress.json. Plugins applied to this property get activated after the theme is activated allowing WP-Cypress to test plugins that depend on the them.

Change Log

  • Adds support for wpContents.pluginsActivatedAfterTheme in cypress.json.
  • wpContents.pluginsActivatedAfterTheme is an array of plugins which will get activated after the theme is.

Types of changes (if applicable):

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist (if applicable):

  • Meets provided linting standards.

To be added to the Schema upon release:

Add this to the wpContents section

Property Required
pluginsActivatedAfterTheme Optional

pluginsActivatedAfterTheme

  • Type: string[]

…the wpContent object in cypress.json which loads plugins after the theme is activated.
@PaulREnglish PaulREnglish changed the base branch from master to release/1.0.0 July 21, 2022 16:05
@PaulREnglish PaulREnglish marked this pull request as ready for review July 22, 2022 08:22
@noplanman
Copy link
Contributor

This new option will also have to be added to lib/schemas/config-validation.json.

Great solution! Nice and simple 👍

@ampersarnie ampersarnie self-requested a review July 25, 2022 11:21
Copy link
Member

@ampersarnie ampersarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected. But as @noplanman pointed out, validation needs to be added for the value in the schema at lib/schemas/config-validation.json.

Happy to approve after that change is made.

@PaulREnglish
Copy link
Contributor Author

Thanks guys, I've added the validation in the lib/schemas/config-validation.json. :D

@ampersarnie ampersarnie merged commit 4d70b29 into release/1.0.0 Jul 26, 2022
@PaulREnglish PaulREnglish mentioned this pull request Jan 25, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants