Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an issue where WP-Cypress could not find cypress/package.json #115

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

PaulREnglish
Copy link
Contributor

Description

In createConfig.js, WP-Cypress could not find the cypress/package.json since the path was a relative one. This PR fixes it by turning it into an absolute path which means that the cypress version can be properly extracted.

Change Log

  • Fixed an issue where WP-Cypress could not find cypress/package.json which means that it wasn't getting the cypress version.

Types of changes (if applicable):

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist (if applicable):

  • Meets provided linting standards.

@PaulREnglish PaulREnglish mentioned this pull request Jan 25, 2023
4 tasks
Copy link
Member

@ampersarnie ampersarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected for me. 🙌

@PaulREnglish PaulREnglish merged commit 21c3ca9 into release/1.0.0 Jan 26, 2023
g-elwell added a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants