[screenshare] Add configuration flag for playStart response, disabled…

… by default (experimental)
bigbluebutton · Oct 27, 2020 · 5c2fbb5 · 5c2fbb5
1 parent 2464665
commit 5c2fbb5
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 6 deletions.
diff --git a/config/custom-environment-variables.yml b/config/custom-environment-variables.yml
@@ -75,6 +75,9 @@ videoSubscriberSpecSlave:
 screenshareSubscriberSpecSlave:
   __name: SCREENSHARE_SUBSCRIBER_SLAVE
   __format: json
+screensharePlayStartEnabled:
+  __name: SCREENSHARE_PLAY_START_ENABLED
+  __format: json
 
 kurentoAllowedCandidateIps:
   __name: KURENTO_ALLOWED_CANDIDATE_IPS

diff --git a/config/default.example.yml b/config/default.example.yml
@@ -45,6 +45,7 @@ common-message-version: 2.x
 screenshareKeyframeInterval: 0
 screenshareEnableFlashRTPBridge: false
 screenshareSubscriberSpecSlave: false
+screensharePlayStartEnabled: false
 videoSubscriberSpecSlave: false
 
 recordScreenSharing: true

diff --git a/lib/screenshare/screenshare.js b/lib/screenshare/screenshare.js
@@ -27,6 +27,9 @@ const SUBSCRIBER_SPEC_SLAVE = config.has('videoSubscriberSpecSlave')
   ? config.get('videoSubscriberSpecSlave')
   : false;
 const KURENTO_REMB_PARAMS = config.util.cloneDeep(config.get('kurentoRembParams'));
+const SCREENSHARE_PLAY_START_ENABLED = config.has(`screensharePlayStartEnabled`)
+  ? config.get(`screensharePlayStartEnabled`)
+  : false;
 
 const LOG_PREFIX = "[screenshare]";
 
@@ -187,12 +190,14 @@ module.exports = class Screenshare extends BaseProvider {
   }
 
   sendPlayStart (role, connectionId) {
-    this.bbbGW.publish(JSON.stringify({
-      type: C.SCREENSHARE_APP,
-      id : 'playStart',
-      connectionId,
-      role,
-    }), C.FROM_SCREENSHARE);
+    if (SCREENSHARE_PLAY_START_ENABLED) {
+      this.bbbGW.publish(JSON.stringify({
+        type: C.SCREENSHARE_APP,
+        id : 'playStart',
+        connectionId,
+        role,
+      }), C.FROM_SCREENSHARE);
+    }
   }
 
   _onViewerWebRTCMediaFlowing (connectionId) {