Allow Listening to Specific Hosts #48
Conversation
This patch allows to listen to a specific host only. For example, when BigBlueButton is used behind Nginx as reverse Proxy, it is completely sufficient to listen to 127.0.0.1 only, but right now there is now easy way to configure that. Note that this patch does not change the default and still works with the previous configuration making updates easy.
This patch allows to have mcs-core listen to a specific host only.
|
@lkiesow thanks for the PR. Agree with the premise, it was an oversight. I'll review and test it. |
|
For the packages, this should probably even be configured to |
|
@lkiesow most of the default configs are piped through the packaging stuff, so it'll probably stay as localhost as in your PR. By the way, we also require a signed Contributor License Agreement from new people making contributions to BBB and its related components. See http://docs.bigbluebutton.org/support/faq.html#why-do-i-need-to-sign-a-contributor-license-agreement-to-contribute-source-code. |
There was a problem hiding this comment.
@lkiesow can you please add environment variable mappings for the new configs you added (clientHost and mcs-host) in /config/custom-environment-variables.yml? Thanks.
This patch changes the default configuration so bbb-webrtc-sfu is only listening to 127.0.0.1 which is enough in the usual environment since it is proxied by Nginx anyway.
This patch adds environment variables to easily change the configuration so that, for example, bbb-webrtc-sfu does not listen only to locahost anymore.
|
Hi @prlanzarin, thanks for the review. I've sent a CLA to Fred though he seems to be pretty under right now. I've also added two commits incorporating your suggestions:
|
|
Hi @prlanzarin, is anything else missing here? |
This patch allows to listen to a specific host only.
For example, when BigBlueButton is used behind Nginx as reverse Proxy,
it is completely sufficient to listen to 127.0.0.1 only, but right now
there is now easy way to configure that.
Note that this patch does not change the default and still works with
the previous configuration making updates easy.