Add global override for tag_required room setting (hiding the UI buttons if used) #5940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ide corresponding room config when override is set)
… accross rails/js
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As suspected, communicating the intent behind the desired/required fallback modes for server tags to regular users turns out relatively difficult in many cases. Thus, some administrators might want to set the fallback mode as global overrides for all users and then hide the option from the user.
Content
This PR adds the possibility for a global override via an environment variable
SERVER_TAG_FALLBACK_MODE, which when set todesiredorrequiredwill override any tag_required room setting and hide the corresponding UI buttons. If not set or set to anything else (like its defaultconfig), the default behavior of per-room configurable fallback mode will apply.Notes
#5936 needs to be merged to make the 'required' fallback mode work properly.