Allow non-numeric postal codes #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cschuijt is attempting to deploy a commit to the Bigcapital Team on Vercel. A member of the Team first needs to authorize it. |
abouolia
approved these changes
Dec 26, 2023
|
Awesome, appreciate your contribution that totally make sense, I've merged it keep contribute. thanks again. @all-contributors please add @cschuijt for bug |
|
I've put up a pull request to add @cschuijt! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some locales, postal codes are not just digits, they can contain letters as well. In the Netherlands, they look like
1234AB. The webapp currently only allows numbers for postal codes, which makes it impossible for me to enter this code there when entering customer or supplier contact info.Since the codes are saved as strings in the database anyway, this PR removes the number validation from the customer/supplier forms and allows the user to enter any string instead. On the backend, everything should work just like it did before.
I ran into this issue while trying to migrate my data into Bigcapital, and since it was a very easy fix, I figured I'd immediately make a pull request out of it. If I missed something or something needs a change, please let me know!