Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why utilizing the 'question' column of the 'ArmelR/stack-exchange-instruction' dataset for gradient backpropagation? #135

Open
HIT-cwh opened this issue Aug 31, 2023 · 1 comment

Comments

@HIT-cwh
Copy link

HIT-cwh commented Aug 31, 2023

Thank you for your valuable open-source contribution!

In instruction tuning stage, it seems that only the answer aligned with the instruction participates in the backpropagation process. And this code seems to imply that the question part of the dataset is also involved in backpropagation of the gradient. Will this lead to better training results?

image

@ArmelRandy
Copy link
Collaborator

Hi. Thank you for reaching out. In this implementation, we do not mask the part of the sequence which corresponds to the question. You can slightly modify the code to account for that. Both methods work reasonably well (masking and not masking) though masking seems to be the standard practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants