Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(component): modal withBorder prop #133

Merged
merged 2 commits into from
Aug 7, 2019
Merged

feat(component): modal withBorder prop #133

merged 2 commits into from
Aug 7, 2019

Conversation

deini
Copy link
Member

@deini deini commented Aug 6, 2019

docs: added modal page

component:

  • Updated padding to match designs: 24px on desktop instead of 32px
  • Updated max-height to match designs: (100% mobile, 90vh tablet, 80vh desk)
  • Added a withBorder boolean prop to <Modal.Header /> and <Modal.Actions /> to support @animesh1987's use case.

Using withBorder on both header and actions:
image

deini added 2 commits August 6, 2019 17:50
@deini
feat(component): modal withBorder prop
26c3e0b 
Added a withBorder prop to <Modal.Actions> and <Modal.Header> also
updated the padding size and moved it from the modal container to
header, body, and actions so we can use optional borders
@deini
feat(docs): add modal page
3f0b961
@deini deini requested a review from a team August 6, 2019 22:56
animesh1987
animesh1987 approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@animesh1987 animesh1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM 👍. Thanks for doing this and also updating the max-height 👏 .

@deini deini merged commit 16780fe into bigcommerce:master Aug 7, 2019
@deini deini deleted the modal branch August 7, 2019 14:54
@chanceaclark chanceaclark mentioned this pull request Oct 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@animesh1987 animesh1987 animesh1987 approved these changes

@rtalvarez rtalvarez rtalvarez approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deini @rtalvarez @animesh1987