feat(component): allow state override of table select all checkbox #224
Conversation
| const { selectAllState, selectedItems } = selectable; | ||
|
|
||
| switch (selectAllState) { | ||
| case 'ALL': |
There was a problem hiding this comment.
🍹 consider putting these strings in a constants definition or similar
| @@ -70,7 +111,8 @@ export const Actions = memo( | |||
| padding="small" | |||
There was a problem hiding this comment.
🍹Could you try and remove the style={{ marginLeft: 'auto' }} on the pagination, and add justifyContent="space-between" to StyledActions? We should try and clean up those style attributes.
There was a problem hiding this comment.
In this case, we have multiple actions, one of them being the itemName so if we do space-between we won't be getting what we want :(
However, I can move this to a custom-styled Flex.
We should add auto to MarginProps
There was a problem hiding this comment.
Ahh yeah, well in that case maybe you could change the Flex.Item for both SelectAll and ItemName to have alignSelf="flex-start" and Pagination alignSelf="flex-end"? 🤷♀️
itemNameprop nos on root level