Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: webpack 5 compatibility #466

Merged
merged 1 commit into from
Oct 20, 2020
Merged

fix: webpack 5 compatibility #466

merged 1 commit into from
Oct 20, 2020

Conversation

deini
Copy link
Member

@deini deini commented Oct 20, 2020

Our @babel/runtime version is broken on Webpack 5 ESM strict mode. Fix is now on @babel/runtime 7.12.0. Bumped the runtime + babel group.

More info: babel/babel#8462

@deini deini requested a review from a team as a code owner October 20, 2020 14:26
@deini deini merged commit 7e66238 into bigcommerce:master Oct 20, 2020
@deini deini deleted the webpack5 branch October 20, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanceaclark chanceaclark chanceaclark approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deini @chanceaclark