Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(component): add primary variant to badge #518

Merged
merged 3 commits into from
Apr 14, 2021
Merged

feat(component): add primary variant to badge #518

merged 3 commits into from
Apr 14, 2021

Conversation

changamanda
Copy link

@changamanda changamanda commented Apr 13, 2021 •
edited by chanceaclark
Loading

Adds a primary variant to the badge

Screen Shot 2021-04-13 at 4 24 22 PM

@changamanda changamanda requested a review from a team as a code owner April 13, 2021 21:30
@changamanda
Copy link
Author

Looks like I don't have permissions to add reviewers/assignee/labels

chanceaclark
chanceaclark reviewed Apr 13, 2021
View reviewed changes
Copy link
Contributor

@chanceaclark chanceaclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, but looks good!

packages/big-design/src/components/Badge/spec.tsx Outdated Show resolved Hide resolved
jorgemoya
jorgemoya approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@jorgemoya jorgemoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great I just would address the one comment. 💯

jordan-massingill
jordan-massingill approved these changes Apr 13, 2021
View reviewed changes
Copy link

@jordan-massingill jordan-massingill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chanceaclark
feat(component): test message change
0a5aec8 
Co-authored-by: Chancellor Clark <chancellorclark@gmail.com>
@changamanda changamanda merged commit e1bacf3 into bigcommerce:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanceaclark chanceaclark chanceaclark left review comments

@jordan-massingill jordan-massingill jordan-massingill approved these changes

@deini deini deini approved these changes

@jorgemoya jorgemoya jorgemoya approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@changamanda @jorgemoya @deini @chanceaclark @jordan-massingill