Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): update modal page to use new layout #618

Merged
merged 2 commits into from
Oct 8, 2021
Merged

feat(docs): update modal page to use new layout #618

merged 2 commits into from
Oct 8, 2021

Conversation

jorgemoya
Copy link
Contributor

@jorgemoya jorgemoya commented Oct 8, 2021 •
edited
Loading

What?

Update Modal page to use new layout

Screenshots/Screen Recordings

modal-2

Testing/Proof

N/A

@jorgemoya jorgemoya requested review from a team as code owners October 8, 2021 16:41
chanceaclark
chanceaclark approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@chanceaclark chanceaclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's simplify the titles of the implementation tabs since there are only two examples.

packages/docs/pages/modal.tsx Outdated
Comment on lines 29 to 30
id: 'modal-variant',
title: 'Modal Variant',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id: 'modal-variant',
title: 'Modal Variant',
id: 'modal',
title: 'Modal',

packages/docs/pages/modal.tsx Outdated
Comment on lines 74 to 75
id: 'dialog-variant',
title: 'Dialog variant',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id: 'dialog-variant',
title: 'Dialog variant',
id: 'dialog',
title: 'Dialog',

@jorgemoya jorgemoya merged commit f44b343 into bigcommerce:master Oct 8, 2021
@jorgemoya jorgemoya deleted the update-modal-page branch October 8, 2021 18:33
@chanceaclark chanceaclark added the documenation This issue is in regards to documentation. label Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanceaclark chanceaclark chanceaclark approved these changes

Assignees
No one assigned
Labels
documenation This issue is in regards to documentation.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgemoya @chanceaclark